From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Date: Wed, 19 Dec 2012 13:30:54 -0500 Message-ID: References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1355941872 12706 80.91.229.3 (19 Dec 2012 18:31:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Dec 2012 18:31:12 +0000 (UTC) Cc: 13225@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 19 19:31:27 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TlOQK-0001xU-Ot for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Dec 2012 19:31:20 +0100 Original-Received: from localhost ([::1]:52626 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlOQ7-0001SR-6P for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Dec 2012 13:31:07 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlOQ3-0001SL-WF for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 13:31:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlOPz-0005iE-KN for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 13:31:03 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlOPz-0005i5-H5 for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 13:30:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TlOQ2-0003RE-2C for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2012 13:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2012 18:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135594186013209 (code B ref 13225); Wed, 19 Dec 2012 18:31:01 +0000 Original-Received: (at 13225) by debbugs.gnu.org; 19 Dec 2012 18:31:00 +0000 Original-Received: from localhost ([127.0.0.1]:51172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlOQ0-0003Qz-Hz for submit@debbugs.gnu.org; Wed, 19 Dec 2012 13:31:00 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:1545) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlOPz-0003Qt-JO for 13225@debbugs.gnu.org; Wed, 19 Dec 2012 13:30:59 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxLDj/2dsb2JhbABEsEiDSYEIghUBAQQBJy8jBQsLNBIUGA0kiBwFugmQRAOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210363639" Original-Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 19 Dec 2012 13:30:55 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 654114E0D7; Wed, 19 Dec 2012 13:30:54 -0500 (EST) In-Reply-To: <83zk1anhzd.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 19 Dec 2012 18:07:18 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68756 Archived-At: > selected_frame = frame; > /* If redisplay causes scrolling, it sets point in the window, so we need to > be careful with the selected-window's point handling. */ > select_window_1 (XFRAME (frame)->selected_window, 0); > This selects the frame, and _also_ makes that frame's selected window > be the global selected_window. Therefore, when display_mode_lines > comes to select a proper face for the mode line, it always finds the > frame's selected window in selected_window, and thus always uses the > face for selected windows. Ah, yes, that makes sense. Of course, when we drop frame-local variables this problem will disappear. Maybe we should live with the "selected_frame->selected_window != selected_window" problem until we get rid of frame-local vars. Stefan