From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP Date: Sat, 26 Jan 2013 17:24:37 -0500 Message-ID: References: <83obgcjisd.fsf@gnu.org> <83ip6kjcy1.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1359246113 9124 80.91.229.3 (27 Jan 2013 00:21:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Jan 2013 00:21:53 +0000 (UTC) Cc: 13553@debbugs.gnu.org, shigeru.fukaya@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 27 01:22:12 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TzG0f-0007GZ-LB for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Jan 2013 01:22:09 +0100 Original-Received: from localhost ([::1]:56829 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzG0N-00088S-Jb for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Jan 2013 19:21:51 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzG0I-00088B-RO for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 19:21:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TzG0H-0004aj-PF for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 19:21:46 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzG0H-0004af-Ld for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 19:21:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TzG0Y-0008NU-1x for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 19:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Jan 2013 00:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13553 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.135924607732140 (code B ref -1); Sun, 27 Jan 2013 00:22:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Jan 2013 00:21:17 +0000 Original-Received: from localhost ([127.0.0.1]:50866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzFzp-0008ML-BT for submit@debbugs.gnu.org; Sat, 26 Jan 2013 19:21:17 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46580) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzFzn-0008MD-07 for submit@debbugs.gnu.org; Sat, 26 Jan 2013 19:21:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TzFzV-0004TX-8P for submit@debbugs.gnu.org; Sat, 26 Jan 2013 19:20:58 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:38164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzFzV-0004TT-5N for submit@debbugs.gnu.org; Sat, 26 Jan 2013 19:20:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzFzT-00085c-As for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 19:20:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TzFzS-0004Sz-93 for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 19:20:55 -0500 Original-Received: from smtp206.alice.it ([82.57.200.102]:56026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzFzR-0004Sn-RE for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 19:20:54 -0500 Original-Received: from fmsmemgm.homelinux.net (82.107.57.105) by smtp206.alice.it (8.6.058.01) id 508F91B90D5102C3 for bug-gnu-emacs@gnu.org; Sun, 27 Jan 2013 01:20:52 +0100 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id ACCD7AE3F4; Sat, 26 Jan 2013 19:20:51 -0500 (EST) Resent-Message-ID: Resent-To: bug-gnu-emacs@gnu.org Resent-From: Stefan Monnier Resent-Date: Sat, 26 Jan 2013 19:20:51 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 17815AE3F4; Sat, 26 Jan 2013 17:24:37 -0500 (EST) In-Reply-To: <83ip6kjcy1.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 26 Jan 2013 15:23:02 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70356 Archived-At: >> > You call file-attributes, which encodes the file name and passes it to >> > 'lstat'. The implementation of 'lstat' in w32.c then looks at the >> > last byte of the encoded file name to see if there's a slash or >> > backslash there. Boom! >> I see. So, does that meant that w32.c can't faithfully implement lstat >> without doing the moral equivalent of re-decoding its argument? > It can, if we limit such support to Windows codepage encodings. See > the changes I made on the emacs-24 branch revisions 111194 and 111200. CharNextExA and CharPrevExA, in my mind, do perform the moral equivalent of decoding the argument (just in an incremental way). > Personally, I think supporting all possible Windows codepages is > good enough. Fine by me, Stefan