unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement.
       [not found] <E1WvlrC-0007Ya-Lc@vcs.savannah.gnu.org>
@ 2014-06-14 21:06 ` Stefan Monnier
  2014-06-15  2:47   ` Eli Zaretskii
  0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2014-06-14 21:06 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 17777

>    if (w->window_end_valid
> +      && NILP (Vexecuting_kbd_macro)
>        && !windows_or_buffers_changed
>        && b
>        && !b->clip_changed

NILP (Vexecuting_kbd_macro) seems like a workaround.  Why can't the
glyph matrix be used in this case?  I means which part of the glyph
matrix is wrong in the OP's recipe (since this makes no change to the
buffer)?


        Stefan





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement.
  2014-06-14 21:06 ` bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement Stefan Monnier
@ 2014-06-15  2:47   ` Eli Zaretskii
  2014-06-15  4:14     ` Stefan Monnier
  0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2014-06-15  2:47 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 17777

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: 17777@debbugs.gnu.org
> Date: Sat, 14 Jun 2014 17:06:28 -0400
> 
> >    if (w->window_end_valid
> > +      && NILP (Vexecuting_kbd_macro)
> >        && !windows_or_buffers_changed
> >        && b
> >        && !b->clip_changed
> 
> NILP (Vexecuting_kbd_macro) seems like a workaround.

It isn't.

> Why can't the glyph matrix be used in this case?

Because cursor position is not up-to-date in that case.

> I means which part of the glyph matrix is wrong in the OP's recipe
> (since this makes no change to the buffer)?

The cursor position.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement.
  2014-06-15  2:47   ` Eli Zaretskii
@ 2014-06-15  4:14     ` Stefan Monnier
  2014-06-15 16:12       ` Eli Zaretskii
  0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2014-06-15  4:14 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 17777

>> >    if (w->window_end_valid
>> > +      && NILP (Vexecuting_kbd_macro)
>> >        && !windows_or_buffers_changed
>> >        && b
>> >        && !b->clip_changed
>> NILP (Vexecuting_kbd_macro) seems like a workaround.
> It isn't.
>> Why can't the glyph matrix be used in this case?
> Because cursor position is not up-to-date in that case.
>> I means which part of the glyph matrix is wrong in the OP's recipe
>> (since this makes no change to the buffer)?
> The cursor position.

But that can occur even without executing kbd macros, no?
Wouldn't it be better to ignore the cursor position given in the glyph
matrix and use (point) instead?


        Stefan





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement.
  2014-06-15  4:14     ` Stefan Monnier
@ 2014-06-15 16:12       ` Eli Zaretskii
  2014-06-16 19:40         ` Eli Zaretskii
  2014-06-16 21:28         ` Stefan Monnier
  0 siblings, 2 replies; 8+ messages in thread
From: Eli Zaretskii @ 2014-06-15 16:12 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 17777

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: 17777@debbugs.gnu.org
> Date: Sun, 15 Jun 2014 00:14:06 -0400
> 
> >> >    if (w->window_end_valid
> >> > +      && NILP (Vexecuting_kbd_macro)
> >> >        && !windows_or_buffers_changed
> >> >        && b
> >> >        && !b->clip_changed
> >> NILP (Vexecuting_kbd_macro) seems like a workaround.
> > It isn't.
> >> Why can't the glyph matrix be used in this case?
> > Because cursor position is not up-to-date in that case.
> >> I means which part of the glyph matrix is wrong in the OP's recipe
> >> (since this makes no change to the buffer)?
> > The cursor position.
> 
> But that can occur even without executing kbd macros, no?

Not sure what you mean by that.

> Wouldn't it be better to ignore the cursor position given in the glyph
> matrix and use (point) instead?

For the method that is based on up-to-date glyph matrices, I need to
know the glyph where the cursor is displayed.  The glyph coordinates
of that glyph are stored in the w->cursor structure, and updated by
redisplay.  The problem in the case in point was that redisplay is not
called as long as a macro is running.  So the coordinates from which
move-point-visually starts are incorrect.

I see no easy way of finding the cursor glyph coordinates by starting
from point; a (not so easy) way is the second method used by that
function.






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement.
  2014-06-15 16:12       ` Eli Zaretskii
@ 2014-06-16 19:40         ` Eli Zaretskii
  2014-06-16 21:50           ` Stefan Monnier
  2014-06-16 21:28         ` Stefan Monnier
  1 sibling, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2014-06-16 19:40 UTC (permalink / raw)
  To: monnier; +Cc: 17777

> Date: Sun, 15 Jun 2014 19:12:29 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 17777@debbugs.gnu.org
> 
> > From: Stefan Monnier <monnier@iro.umontreal.ca>
> > Cc: 17777@debbugs.gnu.org
> > Date: Sun, 15 Jun 2014 00:14:06 -0400
> > 
> > >> >    if (w->window_end_valid
> > >> > +      && NILP (Vexecuting_kbd_macro)
> > >> >        && !windows_or_buffers_changed
> > >> >        && b
> > >> >        && !b->clip_changed
> > >> NILP (Vexecuting_kbd_macro) seems like a workaround.
> > > It isn't.
> > >> Why can't the glyph matrix be used in this case?
> > > Because cursor position is not up-to-date in that case.
> > >> I means which part of the glyph matrix is wrong in the OP's recipe
> > >> (since this makes no change to the buffer)?
> > > The cursor position.
> > 
> > But that can occur even without executing kbd macros, no?
> 
> Not sure what you mean by that.

I think I know now what you meant, and I found a better solution for
the problem (r117250 on the emacs-24 branch).  I hope you will like
it.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement.
  2014-06-15 16:12       ` Eli Zaretskii
  2014-06-16 19:40         ` Eli Zaretskii
@ 2014-06-16 21:28         ` Stefan Monnier
  2014-06-17  2:46           ` Eli Zaretskii
  1 sibling, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2014-06-16 21:28 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 17777

>> But that can occur even without executing kbd macros, no?
> Not sure what you mean by that.

E.g. don't we have the same kind of problem if we use a command like:

   (defun my-wacky-movement ()
     (interactive)
     (dotimes (_ 5)
       (move-point-visually 1)))
or
   (defun my-wacky-movement ()
     (interactive)
     (and (re-search-forward " " nil t)
          (move-point-visually 1)))

If not, why not?

> I see no easy way of finding the cursor glyph coordinates by starting
> from point; a (not so easy) way is the second method used by that
> function.

Then is there a way to check whether point is consistent with the cursor
glyph position (and use this check instead of the
NILP(Vexecuting_kbd_macro) check)?


        Stefan





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement.
  2014-06-16 19:40         ` Eli Zaretskii
@ 2014-06-16 21:50           ` Stefan Monnier
  0 siblings, 0 replies; 8+ messages in thread
From: Stefan Monnier @ 2014-06-16 21:50 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 17777

> I think I know now what you meant, and I found a better solution for
> the problem (r117250 on the emacs-24 branch).  I hope you will like
> it.

Looks good, thanks,


        Stefan





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement.
  2014-06-16 21:28         ` Stefan Monnier
@ 2014-06-17  2:46           ` Eli Zaretskii
  0 siblings, 0 replies; 8+ messages in thread
From: Eli Zaretskii @ 2014-06-17  2:46 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 17777

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: 17777@debbugs.gnu.org
> Date: Mon, 16 Jun 2014 17:28:05 -0400
> 
> >> But that can occur even without executing kbd macros, no?
> > Not sure what you mean by that.
> 
> E.g. don't we have the same kind of problem if we use a command like:
> 
>    (defun my-wacky-movement ()
>      (interactive)
>      (dotimes (_ 5)
>        (move-point-visually 1)))
> or
>    (defun my-wacky-movement ()
>      (interactive)
>      (and (re-search-forward " " nil t)
>           (move-point-visually 1)))

We did, before r117250.

> > I see no easy way of finding the cursor glyph coordinates by starting
> > from point; a (not so easy) way is the second method used by that
> > function.
> 
> Then is there a way to check whether point is consistent with the cursor
> glyph position (and use this check instead of the
> NILP(Vexecuting_kbd_macro) check)?

Indeed, there is.  That's what I did in r117250.





^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2014-06-17  2:46 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1WvlrC-0007Ya-Lc@vcs.savannah.gnu.org>
2014-06-14 21:06 ` bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement Stefan Monnier
2014-06-15  2:47   ` Eli Zaretskii
2014-06-15  4:14     ` Stefan Monnier
2014-06-15 16:12       ` Eli Zaretskii
2014-06-16 19:40         ` Eli Zaretskii
2014-06-16 21:50           ` Stefan Monnier
2014-06-16 21:28         ` Stefan Monnier
2014-06-17  2:46           ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).