From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18510: 24.4.50; ERC doesn't update mode line frequently enough Date: Wed, 24 Sep 2014 09:20:13 -0400 Message-ID: References: <874mw3vg49.fsf@tromey.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1411564907 11713 80.91.229.3 (24 Sep 2014 13:21:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Sep 2014 13:21:47 +0000 (UTC) Cc: 18510@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 24 15:21:40 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XWmVm-0007mv-KX for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Sep 2014 15:21:38 +0200 Original-Received: from localhost ([::1]:59815 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWmVk-00021W-2d for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Sep 2014 09:21:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWmVP-0001bV-Vv for bug-gnu-emacs@gnu.org; Wed, 24 Sep 2014 09:21:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWmVH-00065o-Mx for bug-gnu-emacs@gnu.org; Wed, 24 Sep 2014 09:21:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWmVH-00065D-Kc for bug-gnu-emacs@gnu.org; Wed, 24 Sep 2014 09:21:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XWmVC-0006Os-AK for bug-gnu-emacs@gnu.org; Wed, 24 Sep 2014 09:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Sep 2014 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18510-submit@debbugs.gnu.org id=B18510.141156481824527 (code B ref 18510); Wed, 24 Sep 2014 13:21:02 +0000 Original-Received: (at 18510) by debbugs.gnu.org; 24 Sep 2014 13:20:18 +0000 Original-Received: from localhost ([127.0.0.1]:50532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWmUT-0006NV-F8 for submit@debbugs.gnu.org; Wed, 24 Sep 2014 09:20:17 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:39231) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWmUQ-0006NJ-Id for 18510@debbugs.gnu.org; Wed, 24 Sep 2014 09:20:15 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVOnWBcZ/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSQTh3EI0hkXjnoHhDgEqwODTCE X-IPAS-Result: ArUGAIDvNVOnWBcZ/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSQTh3EI0hkXjnoHhDgEqwODTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="90749202" Original-Received: from 167-88-23-25.cpe.teksavvy.com (HELO ceviche.home) ([167.88.23.25]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 24 Sep 2014 09:20:13 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id B36FF66094; Wed, 24 Sep 2014 09:20:13 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Fri, 19 Sep 2014 14:37:07 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93677 Archived-At: Ping? Stefan >>>>> "Stefan" == Stefan Monnier writes: >>> I've worked around it locally by advising erc-update-mode-line to call >>> (force-mode-line-update t). >> That's not a workaround, that's a fix. > Hmm... not sure what that was about, sorry. Of course, the > (force-mode-line-update t) should only be called when changing > a variable that's visible in the global mode-line-format. > Does the patch below work? > [ I assume the problem is also present in 24.3.93. ] > Stefan > === modified file 'lisp/erc/erc-track.el' > --- lisp/erc/erc-track.el 2014-02-10 01:34:22 +0000 > +++ lisp/erc/erc-track.el 2014-09-19 18:34:57 +0000 > @@ -767,8 +765,7 @@ > (erc-modified-channels-remove-buffer buffer)))) > erc-modified-channels-alist) > (when removed-channel > - (erc-modified-channels-display) > - (force-mode-line-update t))) > + (erc-modified-channels-display))) > (remove-hook 'post-command-hook 'erc-modified-channels-update))) > (defvar erc-track-mouse-face (if (featurep 'xemacs) > @@ -825,9 +822,10 @@ > ((eq 'importance erc-track-switch-direction) > (erc-track-sort-by-importance))) > (run-hooks 'erc-track-list-changed-hook) > - (unless (eq erc-track-position-in-mode-line nil) > - (if (null erc-modified-channels-alist) > - (setq erc-modified-channels-object (erc-modified-channels-object nil)) > + (when erc-track-position-in-mode-line > + (let* ((oldobject erc-modified-channels-object) > + (strings > + (when erc-modified-channels-alist > ;; erc-modified-channels-alist contains all the data we need. To > ;; better understand what is going on, we split things up into > ;; four lists: BUFFERS, COUNTS, SHORT-NAMES, and FACES. These > @@ -858,10 +856,11 @@ > buffers (cdr buffers) > counts (cdr counts) > faces (cdr faces))) > - (when (featurep 'xemacs) > - (erc-modified-channels-object nil)) > - (setq erc-modified-channels-object > - (erc-modified-channels-object strings)))))) > + strings))) > + (newobject (erc-modified-channels-object strings))) > + (unless (equal oldobject newobject) > + (setq erc-modified-channels-object newobject) > + (force-mode-line-update t))))) > (defun erc-modified-channels-remove-buffer (buffer) > "Remove BUFFER from `erc-modified-channels-alist'."