From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#21701: Fwd: cl-typecase broken (was 25.0.50; ert explainer for equal can't handle negative numbers) Date: Fri, 04 Dec 2015 13:17:16 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1449253107 10643 80.91.229.3 (4 Dec 2015 18:18:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Dec 2015 18:18:27 +0000 (UTC) Cc: 21701@debbugs.gnu.org To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 04 19:18:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a4uvr-0003DF-LS for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Dec 2015 19:18:12 +0100 Original-Received: from localhost ([::1]:42297 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4uvq-0004NI-UV for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Dec 2015 13:18:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4uvm-0004ML-DD for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2015 13:18:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4uvi-0007fO-HY for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2015 13:18:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4uvi-0007fK-E6 for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2015 13:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a4uvh-0003nX-Rw for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2015 13:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Dec 2015 18:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21701 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21701-submit@debbugs.gnu.org id=B21701.144925304014549 (code B ref 21701); Fri, 04 Dec 2015 18:18:01 +0000 Original-Received: (at 21701) by debbugs.gnu.org; 4 Dec 2015 18:17:20 +0000 Original-Received: from localhost ([127.0.0.1]:39342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4uv1-0003mb-Sg for submit@debbugs.gnu.org; Fri, 04 Dec 2015 13:17:20 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:64951) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4uuz-0003mS-EB for 21701@debbugs.gnu.org; Fri, 04 Dec 2015 13:17:17 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CvCwA731xV/yr292hcgxCEAsEMCYdHBAQCAoE8ORQBAQEBAQEBgQpBBYNdAQEDAVYjBQsLDiYSFBgNJIg3CM8jAQEIAgEfizqFBQeELQWGaIVIL6glI4IKHBWBWyCCeAEBAQ X-IPAS-Result: A0CvCwA731xV/yr292hcgxCEAsEMCYdHBAQCAoE8ORQBAQEBAQEBgQpBBYNdAQEDAVYjBQsLDiYSFBgNJIg3CM8jAQEIAgEfizqFBQeELQWGaIVIL6glI4IKHBWBWyCCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="184495577" Original-Received: from 104-247-246-42.cpe.teksavvy.com (HELO pastel.home) ([104.247.246.42]) by ironport2-out.teksavvy.com with ESMTP; 04 Dec 2015 13:17:17 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 8E47E61753; Fri, 4 Dec 2015 13:17:16 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Fri, 04 Dec 2015 12:36:55 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109610 Archived-At: > That's indeed what should be done if ERT needs this to be a plain > character that can inserted in a string. Common-Lisp's `character' > includes not just characters but also "characters with modifiers" such > as ?\M-\H-=E9, which can't appear in a string and are rejected by > `characterp'. I installed a patch which makes ERT use pcase over cl-typecase. In most cases it doesn't make a big difference, but in a few spots, it is cleaner because a subsequent cl-destructuring-bind can be merged into it (and it got rid of those places where we used (member :foo) as a type to just check equality, which is rather inefficient). Stefan