From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#35487: Make visiting function from help-mode more customizable Date: Thu, 16 May 2019 16:25:11 -0400 Message-ID: References: <20190429.213014.526232842075202623.tkk@misasa.okayama-u.ac.jp> <87sgu0wps5.fsf@mail.linkov.net> <8636lnp6lm.fsf@misasa.okayama-u.ac.jp> <86zhnmn5mc.fsf@misasa.okayama-u.ac.jp> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="20994"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35487@debbugs.gnu.org, tkk@misasa.okayama-u.ac.jp, Juri Linkov To: Tak Kunihiro Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 16 22:26:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRMxJ-0005KF-8D for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2019 22:26:21 +0200 Original-Received: from localhost ([127.0.0.1]:35658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRMxI-0007sR-88 for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2019 16:26:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRMx5-0007s1-EL for bug-gnu-emacs@gnu.org; Thu, 16 May 2019 16:26:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRMx2-0005hv-7P for bug-gnu-emacs@gnu.org; Thu, 16 May 2019 16:26:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43021) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRMx0-0005g9-2a for bug-gnu-emacs@gnu.org; Thu, 16 May 2019 16:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hRMwz-00033z-Sb for bug-gnu-emacs@gnu.org; Thu, 16 May 2019 16:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 May 2019 20:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35487 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35487-submit@debbugs.gnu.org id=B35487.155803832011690 (code B ref 35487); Thu, 16 May 2019 20:26:01 +0000 Original-Received: (at 35487) by debbugs.gnu.org; 16 May 2019 20:25:20 +0000 Original-Received: from localhost ([127.0.0.1]:56562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRMwK-00032T-Ft for submit@debbugs.gnu.org; Thu, 16 May 2019 16:25:20 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRMwJ-00032D-9t for 35487@debbugs.gnu.org; Thu, 16 May 2019 16:25:19 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BE5BE100B97; Thu, 16 May 2019 16:25:13 -0400 (EDT) Original-Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7552F1007CC; Thu, 16 May 2019 16:25:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558038312; bh=tP3+oADLq6wsHynLnulLXqKV8ppebVIikl9T8RC3ni8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MoI3Qel8Q3SDMg+Hy6GFtZoAoT6Sk6zHB57b2SxVsWfEy/aKAw/G6UHvKdmk4PVb1 2RVgtwOO4TaAnSPJKTTdlMIHOUDcm1XZOX8u0Otn5aCL8vgHgRsmrkm/RQHrQgajLZ WrlaWD7b8MptZQALtZKp9jPN1XCD/1zJscqemJYXaw0sfd5y1LXbtjf0aG+kuRt571 j4jI2cwReEv3GePYsbzpYRZjpET52h5ILSHAPlOfKfoAfJZaBSUWSuxT/mU9PGLsD9 yus6WYvnnL0W84arfa4MF/z8AUdE4eA9+536FoVbXIo+6ATccSzY5xEVQlF15lFxoS YGNcGJ4DuAhtw== Original-Received: from ceviche (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 4D196120893; Thu, 16 May 2019 16:25:12 -0400 (EDT) In-Reply-To: <86zhnmn5mc.fsf@misasa.okayama-u.ac.jp> (Tak Kunihiro's message of "Thu, 16 May 2019 17:52:27 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159411 Archived-At: > (define-key help-mode-map (kbd "f") 'push-button-display-buffer) > > (defun push-button-display-buffer (&optional action) > (interactive) > (or action (setq action 'display-buffer-same-window)) > (let ((display-buffer-alist > `((display-buffer-condition-from-help ,action)))) > (push-button))) > > (defun display-buffer-condition-from-help (_buffer-name _action) > (with-current-buffer (window-buffer) > (eq major-mode 'help-mode))) I think the display-buffer-condition-from-help (which likely should have a final "-p" in its name) is only needed you you want to add it to the global value of display-buffer-alist. In the above code, since you're using a specific binding in help-mode-map, you presumably already know that (eq major-mode 'help-mode) so you can just rebind display-buffer-overriding-action. BTW, this is a case where you could use the same approach as used in the `other-frame-window` package but using a prefix command which says "use the same window for the next command". Stefan