From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core Date: Tue, 09 Mar 2021 15:49:38 -0500 Message-ID: References: <87y2f0fq8v.fsf@protesilaos.com> <87sg58tkg7.fsf@tcd.ie> <87h7lofe6b.fsf@protesilaos.com> <87mtvfpgf2.fsf@protesilaos.com> <878s6wqq40.fsf@tcd.ie> <874khk6t7d.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="890"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 46964@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 09 22:04:56 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJjXE-00005n-A0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 22:04:56 +0100 Original-Received: from localhost ([::1]:57990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJjXD-0005I1-9J for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 16:04:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJjIp-0002Ug-5s for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 15:50:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36530) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJjIo-0001T6-Kd for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 15:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJjIo-0007JE-H1 for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 15:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Mar 2021 20:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46964-submit@debbugs.gnu.org id=B46964.161532299028074 (code B ref 46964); Tue, 09 Mar 2021 20:50:02 +0000 Original-Received: (at 46964) by debbugs.gnu.org; 9 Mar 2021 20:49:50 +0000 Original-Received: from localhost ([127.0.0.1]:48076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJjIc-0007Ik-5J for submit@debbugs.gnu.org; Tue, 09 Mar 2021 15:49:50 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJjIZ-0007IV-6y for 46964@debbugs.gnu.org; Tue, 09 Mar 2021 15:49:48 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 590A3440B04; Tue, 9 Mar 2021 15:49:41 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0C65E440B32; Tue, 9 Mar 2021 15:49:40 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615322980; bh=fslWOkERKU8ScMri+s7zM6Xfrg+oqoiclAFyziNLLhM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=TpCawRq/Y3WJB3AcmGA2jX7TusDi/F9/EOLoV8VTgDZp1/S9e54Ibmsz2OqbkQHOs f2KPDL4VBuD31lMhGRLU2oum5Y/t7FiRjjUwZjEQDgAvkm60CSudJvii8vQp4he2G6 t0Lk4sAvgh8X/6zVl46G+H6dp68s5hCDXRcPnf35IwK/UYA9WMiGkB3kIlYAXn0sHd rigpJDseGvO/Jf2bgUr1UOOg/5g4NNj9PGwBfsXJmx0bBkPuzWoyR5Mmk+ZdlzXZ3g laFZsGOx4rZgLCSB6H7dpxxAO7+AidhjAWQ3TIsCicClyOd1W7p8CfmBNMSrcPWNBW N+NQAtehTt7gg== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 047B8120296; Tue, 9 Mar 2021 15:49:39 -0500 (EST) In-Reply-To: <874khk6t7d.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Tue, 09 Mar 2021 21:08:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201946 Archived-At: Protesilaos Stavrou [2021-03-09 21:08:22] wrote: > On 2021-03-09, 15:54 +0000, "Basil L. Contovounesios" wrote: > >> Protesilaos Stavrou writes: >> >>> Thank you! I have amended the patch using the format you recommended. >> >> Thanks, LGTM. >> >> Have you been able to verify that the tarball is created properly, >> and especially that the contained .info file is nonempty? > > No, the build always gives me errors. Though I assumed something was > wrong on my end (I am not familiar with makefiles). This is not just > with the modus-themes. Same for something like project.el. Please see > the attached file with the backtrace. Hmm... indeed. Can you check if the patch below fixes it for you? Stefan diff --git a/elpa-admin.el b/elpa-admin.el index 5cb3d261c5..62ba1abcf2 100644 --- a/elpa-admin.el +++ b/elpa-admin.el @@ -246,7 +246,7 @@ Do it without leaving the current branch." (expand-file-name (elpaa--main-file pkg-spec) dir))) (default-directory (file-name-directory ftn))) (vc-working-revision ftn)))) - (if (equal rev cur-rev) + (if (or (not rev) (equal rev cur-rev)) (elpaa--message "Current revision is already desired revision!") (with-temp-buffer (let ((default-directory (elpaa--dirname dir)))