From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#41988: 28.0.50; Edebug unconditionally instruments definitions with &define specs Date: Sun, 21 Mar 2021 10:37:44 -0400 Message-ID: References: <6D19F14E-0133-4751-B0BD-EC2A73C1D21F@gmail.com> <3619E155-8F06-4F8F-B239-121ED3D164A8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19663"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41988@debbugs.gnu.org To: Philipp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 21 15:38:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNzDW-00050i-5e for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 15:38:10 +0100 Original-Received: from localhost ([::1]:44792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNzDV-0006o4-7d for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 10:38:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNzDO-0006no-Oq for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 10:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43687) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNzDO-0002oC-HP for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 10:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNzDO-0002vB-ES for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 10:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Mar 2021 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41988 X-GNU-PR-Package: emacs Original-Received: via spool by 41988-submit@debbugs.gnu.org id=B41988.161633747711218 (code B ref 41988); Sun, 21 Mar 2021 14:38:02 +0000 Original-Received: (at 41988) by debbugs.gnu.org; 21 Mar 2021 14:37:57 +0000 Original-Received: from localhost ([127.0.0.1]:55233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNzDJ-0002ur-2t for submit@debbugs.gnu.org; Sun, 21 Mar 2021 10:37:57 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:8717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNzDE-0002uU-UT for 41988@debbugs.gnu.org; Sun, 21 Mar 2021 10:37:55 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5B83D8024F; Sun, 21 Mar 2021 10:37:47 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DBE6980385; Sun, 21 Mar 2021 10:37:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616337465; bh=PBJ6BSrYjf/JVPeSB8LqLXOYjF8HeAXKqTQUESEfGx4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=U+RHTNOpdKXOFThU0yALyVp6AtDyXIDmo6ohvCDkbR2R0MKJBHHtfMcRRB1PEE/Dy c/RkpC/zTuYC7rCJ3imyvwepHo4/oONDtgF9/A3nmpvQwyXYrpavPbcRSETphWzCg+ zCH0sqK4RXmSHmqhmvE6IBB4taXgi/70dSSzSb3N8+u+3JE4IpviVQjtZsgD5IdmJE CbG6IZT5iIdJTDsxlmJlbnxNICGgUoUqtxEITCKuGwDPmJmp8909qSOcdxzp33MKa5 tpsiDk3C00TfPkDtpHVSgwgjdUfaNDR1jGqQl4bhf2Ttjc/rpmr0iujbZQlcspTpeR t+5qMOiWq4jAg== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B3D7312016F; Sun, 21 Mar 2021 10:37:45 -0400 (EDT) In-Reply-To: <3619E155-8F06-4F8F-B239-121ED3D164A8@gmail.com> (Philipp's message of "Sun, 21 Mar 2021 14:34:08 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202777 Archived-At: >> - The old spec of `cl-flet` would be broken by such a change, so if we >> want to make such a change, we'd probably want to arrange so that it >> emits a clear warning. > Where? When setting the debug specification (byte-run--set-debug), or in some other place? The old spec was of the form (or (&define name form) (&define name sexp body)), so if we put a gate at `&define`, this will probably fail to even match the (&define name sexp body) part. [ Disclaimer: I don't understand the precise semantics of `gate`, tho I do remember using it once via trial-and-error. So maybe it wouldn't prevent it, but if doesn't prevent it, then it doesn't likely "fix" our problem ;-) ] >> I'm not sure it's worth the trouble: the pain seems higher than the gain. > This bug is rather nasty when it's hit (it took me quite a while to > debug/hunt down), Could you remind me what was this nasty outcome? In the context of Edebug the effect is negligible (it just emits a spurious message about defining an extra something, but other than that debugging works just fine). > so I think it would be reasonable to prevent. We already > disable backtracking for literal symbols, and I think forms that require > multiple &define forms with backtracking should be exceedingly rare and can > be rewritten as you did with cl-flet. Emitting a warning would be much more helpful than just silently "cut"ting the backtracking. Stefan