From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49053: Error (setf seq-elt) is already defined as something else than a generic function Date: Tue, 15 Jun 2021 22:29:24 -0400 Message-ID: References: <874kdyn615.fsf@mail.linkov.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5645"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49053@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 16 04:30:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltLK3-0001G4-N4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Jun 2021 04:30:31 +0200 Original-Received: from localhost ([::1]:45988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltLK2-000145-KX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Jun 2021 22:30:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltLJd-00013o-Na for bug-gnu-emacs@gnu.org; Tue, 15 Jun 2021 22:30:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39588) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ltLJa-0003Ia-RF for bug-gnu-emacs@gnu.org; Tue, 15 Jun 2021 22:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ltLJa-0005Qw-PC for bug-gnu-emacs@gnu.org; Tue, 15 Jun 2021 22:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Jun 2021 02:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49053 X-GNU-PR-Package: emacs Original-Received: via spool by 49053-submit@debbugs.gnu.org id=B49053.162381057520830 (code B ref 49053); Wed, 16 Jun 2021 02:30:02 +0000 Original-Received: (at 49053) by debbugs.gnu.org; 16 Jun 2021 02:29:35 +0000 Original-Received: from localhost ([127.0.0.1]:51134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltLJ9-0005Pu-If for submit@debbugs.gnu.org; Tue, 15 Jun 2021 22:29:35 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltLJ7-0005Pg-8P for 49053@debbugs.gnu.org; Tue, 15 Jun 2021 22:29:34 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 05A2C808AB; Tue, 15 Jun 2021 22:29:27 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A42C6806F0; Tue, 15 Jun 2021 22:29:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1623810565; bh=9JVTYdPCSlO2WiZVaQFpr7G6V6jQCJgv42gq8rsel9Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=K880ffL/DAK4r+fwiOKqz5ZDfHKACSYICUkuLWRMg1L2j6gqePj1ANI1R+byAWdYh K1q64pagtf3F2lJBd/psp19YASNVd9eNZnXs9bFMfB64Xu15IwquKEe/4TMedcL3vx +Yg5kjmm8iP39XZZd4EuDM2A35FKW2bBnZLQSZHyAc2vUUmTmcb5nf0YeXh9lE9rVi cep/G+DmxfxnNR7EIKBmUeE80BakdjLW8ozQ3qHOeSJAHQe7MiX2UpCnQMkI9Coimg mAYBBCIn40/6k9i112pgvL1vVrYNy6zQl4dkXmsZS2/4SpepeAuF8hHXL+j0aBZ4e8 8oJX2jbTzJkyQ== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 737221207BC; Tue, 15 Jun 2021 22:29:25 -0400 (EDT) In-Reply-To: <874kdyn615.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 16 Jun 2021 00:59:18 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208615 Archived-At: > Then evaluated symbol-function again that returned a different value: > > (symbol-function '\(setf\ seq-elt\)) > => dummy I don't really understand why that would happen, but maybe too much happens during `cl--generic-make-function`. Does the patch below help? Stefan diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el index 31aa0cb4f9..544704be38 100644 --- a/lisp/emacs-lisp/cl-generic.el +++ b/lisp/emacs-lisp/cl-generic.el @@ -568,17 +568,17 @@ cl-generic-define-method (cons method mt) ;; Keep the ordering; important for methods with :extra qualifiers. (mapcar (lambda (x) (if (eq x (car me)) method x)) mt))) - (let ((sym (cl--generic-name generic))) ; Actual name (for aliases). + (let ((sym (cl--generic-name generic)) ; Actual name (for aliases). + ;; FIXME: Try to avoid re-constructing a new function if the old one + ;; is still valid (e.g. still empty method cache)? + (gfun (cl--generic-make-function generic))) (unless (symbol-function sym) (defalias sym 'dummy)) ;Record definition into load-history. (cl-pushnew `(cl-defmethod . ,(cl--generic-load-hist-format (cl--generic-name generic) qualifiers specializers)) current-load-list :test #'equal) - ;; FIXME: Try to avoid re-constructing a new function if the old one - ;; is still valid (e.g. still empty method cache)? - (let ((gfun (cl--generic-make-function generic)) - ;; Prevent `defalias' from recording this as the definition site of + (let (;; Prevent `defalias' from recording this as the definition site of ;; the generic function. current-load-list ;; BEWARE! Don't purify this function definition, since that leads