unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: clemera@posteo.net
Cc: 45177@debbugs.gnu.org
Subject: bug#45177: 27.1; Access to invoking top level command in minibuffer
Date: Mon, 02 Aug 2021 00:03:32 -0400	[thread overview]
Message-ID: <jwvy29k8pey.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwvpmuwaj0o.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 01 Aug 2021 18:42:05 -0400")

[ Resending because of that damn archiving misfeature.  ]

clemera@posteo.net [2020-12-11 15:20:34] wrote:
> For command based settings it would be nice to be able to have
> access to the top level command from which the current minibuffer
> session was invoked from. This should also work with multiple minibuffer
> invokations during a command. Using `minibuffer-setup-hook' to save
> `real-this-command' does not work, for example with:
>
> ```elisp
> (defun example-command ()
>   (interactive)
>   (read-string "Example: ")
>   (message "%s" real-this-command))
> ```
>
> `real-this-command' will be `exit-minibuffer' after the `read-string' so any
> minibuffer invokation within that command afterwards will no longer know
> about `example-command'.

If you invoke `example-command` from an alias, you won't get "the right"
answer either anyway.

> The described issue is problem for completion frameworks. The popular
> Ivy(https://github.com/abo-abo/swiper/) package from GNU ELPA does use the
> `:caller` argument passed to `ivy-read` to circumvent this. With
> Selectrum(https://github.com/raxod502/selectrum/) we are trying to find
> a built-in way to handle this.

I think this is an XY problem.

Changing the behavior based on the caller's name is a very bad idea.
It's a bit like `called-interactively-p`, except it's worse because
you're looking for even more ill-defined data than just a boolean.

The standard UI has introduced the `category` metadata for that kind
of problems.  I don't claim it's a perfect solution, but whichever
"right" solution we come up with it should not be based on the name of
the caller but instead it should be based on data provided by
the caller.


        Stefan






  parent reply	other threads:[~2021-08-02  4:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11 14:20 bug#45177: 27.1; Access to invoking top level command in minibuffer clemera
2020-12-11 17:35 ` Drew Adams
2020-12-12 13:28   ` Clemens
2020-12-12 13:39   ` clemera
2020-12-11 20:41 ` Lars Ingebrigtsen
2020-12-12 13:31   ` clemera
2020-12-13 12:29     ` Lars Ingebrigtsen
2020-12-13 13:29       ` clemera
2020-12-14 15:45         ` Lars Ingebrigtsen
2020-12-14 17:52           ` Clemens
2020-12-14 18:01           ` Clemens
2020-12-15  6:18             ` Lars Ingebrigtsen
2020-12-15 11:58               ` Clemens
     [not found]           ` <jwvk0l4ail0.fsf-monnier+emacs@gnu.org>
2021-08-02  4:04             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-04  5:49               ` Lars Ingebrigtsen
2020-12-13 13:39       ` clemera
2020-12-13 14:16       ` clemera
2021-01-12  8:46         ` Clemens
2020-12-12 20:14   ` Juri Linkov
2020-12-12 21:25     ` clemera
2020-12-13  8:47       ` Juri Linkov
2020-12-13 11:40         ` clemera
2020-12-13 11:45         ` clemera
     [not found] ` <jwvpmuwaj0o.fsf-monnier+emacs@gnu.org>
2021-08-02  4:03   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-08-04  5:51     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvy29k8pey.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=45177@debbugs.gnu.org \
    --cc=clemera@posteo.net \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).