From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 56469@debbugs.gnu.org
Subject: bug#56469: 29.0.50; Unibyte dir in directory_files_internal
Date: Sun, 10 Jul 2022 11:19:22 -0400 [thread overview]
Message-ID: <jwvy1x180c3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83a69h0zwz.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Jul 2022 18:07:24 +0300")
> That could be the situation _today_, but that's just sheer luck (or
> lack thereof). In general, all the file-handling code we have in
> fileio.c and dired.c should be equally prepared to handle unibyte
> non-ASCII file names and multibyte file names, because we may need
> that any time. When we make changes in Emacs, we shouldn't be worried
> whether those changes could cause some dired.c code be called early on
> during Emacs startup.
Agreed. In the updated comment I noted that we have a bug when we do
(let ((file-name-coding-system 'binary))
(directory-files "/tmp/été/" 'full)
because we'll be concatenating the multibyte string "/tmp/été/" with
the undecoded unibyte strings of the names of files in that directory.
Stefan
next prev parent reply other threads:[~2022-07-10 15:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 17:44 bug#56469: 29.0.50; Unibyte dir in directory_files_internal Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-09 18:17 ` Eli Zaretskii
2022-07-09 18:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-09 18:53 ` Eli Zaretskii
2022-07-10 14:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-10 14:32 ` Eli Zaretskii
2022-07-10 14:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-10 15:07 ` Eli Zaretskii
2022-07-10 15:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-07-10 15:41 ` Eli Zaretskii
2022-07-10 22:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-11 2:27 ` Eli Zaretskii
2022-09-05 19:21 ` Lars Ingebrigtsen
2022-09-07 13:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy1x180c3.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=56469@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).