From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56739: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize symbol macros Date: Mon, 05 Sep 2022 22:29:24 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36634"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56739@debbugs.gnu.org To: Wing Hei Chan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 06 04:30:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVOLx-0009Kl-BS for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 04:30:17 +0200 Original-Received: from localhost ([::1]:55264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVOLv-0001Ks-KA for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Sep 2022 22:30:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVOLi-0001KX-QP for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 22:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVOLi-0005nf-DB for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 22:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVOLi-0004UQ-3Y for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 22:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2022 02:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56739 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56739-submit@debbugs.gnu.org id=B56739.166243137617206 (code B ref 56739); Tue, 06 Sep 2022 02:30:02 +0000 Original-Received: (at 56739) by debbugs.gnu.org; 6 Sep 2022 02:29:36 +0000 Original-Received: from localhost ([127.0.0.1]:49263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVOLH-0004TR-LC for submit@debbugs.gnu.org; Mon, 05 Sep 2022 22:29:35 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVOLF-0004TF-RM for 56739@debbugs.gnu.org; Mon, 05 Sep 2022 22:29:34 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A8080807C3; Mon, 5 Sep 2022 22:29:27 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 579F880070; Mon, 5 Sep 2022 22:29:26 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1662431366; bh=5BOMamr5+Jrxc7FrS6nciS9zS/eRY1u10GKfsWshzsg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=n5dHqem7MsAsYZAGxhlZ+1lMU7cGbfCAWmbmmfVFP0z2XeE3PhJ7XJDFp+ecvGoNo VqXoMXwVn/Io1YSHkjHIc4Jimabg7OHR2wOlrifsV53ft+5tQdDSZUzckcN7rkuR7k DVtuF2lbhcAOhrks7e7kl7hYkpAHUF2s0dnzJV9WPx+vItuyhW3Q1iHMO9n4/yt4nO lPFpgwM7ofc8btYkbI5oXzCURn8DBwAkdY6G0Icmvrl+SvobtQjL2NKjs3M2Yb4y0x sNGBJtj9uSSbrfesaNhxPyA7IoZ9Mt6MIX1quPYHscHzfW0PxgI45nI8yiXRJxdInv nLgvPkn+lncdw== Original-Received: from pastel (unknown [157.52.9.190]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 27B63120748; Mon, 5 Sep 2022 22:29:26 -0400 (EDT) In-Reply-To: (Wing Hei Chan's message of "Sun, 24 Jul 2022 20:12:10 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241612 Archived-At: > The following form produces (2 2) due to the failure of detecting > dependencies involving symbol macros. > > (cl-symbol-macrolet ((c a)) > (let ((a 1) (b 2)) > (cl-psetq a b > b c) > (list a b))) BTW, another way to get similar problems is with `defvaralias`: (defvaralias 'my-c 'my-a) (defvar my-a 1) (let ((b 2)) (cl-psetq my-a b b my-c) (list my-a b)) We should probably introduce a `(macroexp|cl)--simple-var-p` test to catch the various cases where symbols aren't simple variables. Another thing that might be worth digging into is how important is that `cl-psetf` optimization for lexical variables (remember: this was written back in the days of dynamic scoping and Mattias has made some improvements to the compiler which may render this optimization redundant inside the macro itself. Stefan