From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58041: [PATCH] docview: Use svg images when using mupdf for conversion Date: Thu, 12 Jan 2023 16:11:04 -0500 Message-ID: References: <87k05t848c.fsf@gmail.com> <87eds5zhf7.fsf@gmail.com> <87v8lfy8g5.fsf@gmail.com> <87fscgxng0.fsf@gmail.com> <87zganwvgp.fsf@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36716"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58041@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 12 22:12:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pG4s7-0009Ie-9J for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Jan 2023 22:12:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pG4rl-0001PC-1p; Thu, 12 Jan 2023 16:12:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pG4ri-0001Os-Ba for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 16:12:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pG4ri-0002Ii-22 for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 16:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pG4rh-0002Zc-TF for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 16:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Jan 2023 21:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58041 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58041-submit@debbugs.gnu.org id=B58041.16735578769838 (code B ref 58041); Thu, 12 Jan 2023 21:12:01 +0000 Original-Received: (at 58041) by debbugs.gnu.org; 12 Jan 2023 21:11:16 +0000 Original-Received: from localhost ([127.0.0.1]:48697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG4qx-0002Yc-JC for submit@debbugs.gnu.org; Thu, 12 Jan 2023 16:11:15 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG4qu-0002YP-W3 for 58041@debbugs.gnu.org; Thu, 12 Jan 2023 16:11:13 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2194244178C; Thu, 12 Jan 2023 16:11:07 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7DF914421D5; Thu, 12 Jan 2023 16:11:05 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1673557865; bh=hyVs2451SkvW3gTk/vunQNl/HGy9RhEqYqXZzf/m0xA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=AKBx0j/yua3ZoZGFFrNPvBb6ov3PzNVSTjro5Uzwo8eMsGctbuK4MKZ+F2dvcQkry 70a5HPSkEgjMXSp0tcgg0ZVHgGWI+S17yh+B6Tl9XDpp1FJFh4sQpcn4flHhTyUozB S9Qjpfsaz3sDpemfzR+WFHLbW/Onn2iriLt8m20U3l+yHdLBb0qspuBjAv6Hqx66yr EixaMDSaZ9onI/jC3gl/RxlJINLHFermveSQwf1ZDQgb6NluXahnY0Wj6cSDMbKlAQ DyG8PaijQZfzdnETW/YIzS1pK6Boj/LRHNRKcdYmIB/q6kqpyJLzO//KCa4ITu/hvV IXDuwuRRCsAgw== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4D5321208F8; Thu, 12 Jan 2023 16:11:05 -0500 (EST) In-Reply-To: <87zganwvgp.fsf@gmail.com> (Visuwesh's message of "Thu, 12 Jan 2023 22:17:50 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253245 Archived-At: > @@ -489,7 +489,7 @@ doc-view-single-page-converter-function > > (defvar-local doc-view--image-type nil > "The type of image in the current buffer. > -Can be `png' or `tiff'.") > +Can be `png', `svg', or `tiff'.") > > (defvar-local doc-view--image-file-pattern nil > "The `format' pattern of image file names. > @@ -921,7 +921,9 @@ doc-view-shrink-factor > (defun doc-view-enlarge (factor) > "Enlarge the document by FACTOR." > (interactive (list doc-view-shrink-factor)) > - (if doc-view-scale-internally > + (if (or doc-view-scale-internally > + (and (eq doc-view--image-type 'svg) > + doc-view-mupdf-use-svg)) > (let ((new (ceiling (* factor doc-view-image-width)))) > (unless (equal new doc-view-image-width) > (setq-local doc-view-image-width new) > @@ -941,7 +943,9 @@ doc-view-shrink > (defun doc-view-scale-reset () > "Reset the document size/zoom level to the initial one." > (interactive) > - (if doc-view-scale-internally > + (if (or doc-view-scale-internally > + (and (eq doc-view--image-type 'svg) > + doc-view-mupdf-use-svg)) > (progn > (kill-local-variable 'doc-view-image-width) > (doc-view-insert-image Looks OK to me, tho I wonder why we still need to check `doc-view-mupdf-use-svg`. Isn't it sufficient to check (eq doc-view--image-type 'svg)? Stefan