From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sun, 16 Jul 2023 10:49:16 -0400 Message-ID: References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <83r0p9b3om.fsf@gnu.org> <83jzv1b152.fsf@gnu.org> <83a5vxas9k.fsf@gnu.org> <871qh8o12z.fsf@localhost> <83r0p87wyq.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26826"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: yantar92@posteo.net, 64596@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 16:50:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qL34p-0006lm-HW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 16:50:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qL34Y-0005AM-1D; Sun, 16 Jul 2023 10:50:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL34V-00059d-0s for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 10:50:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qL34U-0004F1-Gx for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 10:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qL34U-0006Q0-Ch for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 10:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 14:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168951896524585 (code B ref 64596); Sun, 16 Jul 2023 14:50:02 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 16 Jul 2023 14:49:25 +0000 Original-Received: from localhost ([127.0.0.1]:48393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL33t-0006OT-8G for submit@debbugs.gnu.org; Sun, 16 Jul 2023 10:49:25 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:13241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL33r-0006OA-V0 for 64596@debbugs.gnu.org; Sun, 16 Jul 2023 10:49:24 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4B22B1000C4; Sun, 16 Jul 2023 10:49:18 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5FCF5100097; Sun, 16 Jul 2023 10:49:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689518957; bh=R3zygOJtMTDta3gIdysw7HG/GMQZoYAWGI9Y4wq0QV8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JFmxJucESAm6mZGDUQ6Q2xKCQ67Fcp2OYP1LjbAkLYrsyFJYixXhCiz3Yi0IPLnrt KH3gVuFz9jYwdMK9CKox+OO+7LsLC7FyJ1b7Uzv+U8pbfUbuFN7bidcJc0B/JXGoEw EpTMton2OVNJ2SnO/6dWlUE2NzcSdIfEXI/cpT/rO1exWpVzkGs1chzXc2RRtkCjoq 3pGgcCtAsX6aAXDvyXmg6m7LUqlwY36FUTvKSBob/NLS9q+jj2bOASZgAKFAZr2umU VpWrcNaoskQGfPp0VcT277Y0xXBI+HOK/Wy7zt7q4ot584JKvs1u5yEiWDO2jzKccN YIljMB3JPXvJQ== Original-Received: from pastel (unknown [108.175.226.218]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 321451202E0; Sun, 16 Jul 2023 10:49:17 -0400 (EDT) In-Reply-To: <83r0p87wyq.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 16 Jul 2023 17:27:41 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265346 Archived-At: > So it sounds like we should make sure we don't set the frame's > redisplay flag unless most or all of its windows actually need to be > considered. Is this so with the current code? Indeed, the frame's `redisplay` bit means "*all* windows in that frame need to be redisplayed", so it should be set with care. But since the code before that only had a single boolean for "redisplay all windows on all frames", I was often happy enough to replace the global redisplay with `fset_redisplay` even though it might be possible to be more specific. `fset_redisplay` is typically used when windows are added/deleted/resized, because it's hard at that point to know which windows really need to be updated. Stefan