From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71419: 30.0.50; Completion does not always highlight the "common part" corresponding to suffix Date: Sun, 09 Jun 2024 17:06:42 -0400 Message-ID: References: <96abea7d-3e18-4a81-8b6c-79dd0b496420@gutov.dev> <1dc364dc-1a16-4de4-9372-767906494610@gutov.dev> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25694"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71419@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 09 23:08:00 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGPlg-0006Rw-AM for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jun 2024 23:08:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGPlT-0000cH-LB; Sun, 09 Jun 2024 17:07:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGPlR-0000bs-Hy for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 17:07:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGPlR-0004al-8w for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 17:07:45 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sGPlh-00048h-Pk for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 17:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2024 21:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71419 X-GNU-PR-Package: emacs Original-Received: via spool by 71419-submit@debbugs.gnu.org id=B71419.171796722815757 (code B ref 71419); Sun, 09 Jun 2024 21:08:01 +0000 Original-Received: (at 71419) by debbugs.gnu.org; 9 Jun 2024 21:07:08 +0000 Original-Received: from localhost ([127.0.0.1]:60817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGPkp-000461-O9 for submit@debbugs.gnu.org; Sun, 09 Jun 2024 17:07:08 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGPko-00045R-8f for 71419@debbugs.gnu.org; Sun, 09 Jun 2024 17:07:06 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4DF1880882; Sun, 9 Jun 2024 17:06:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1717967203; bh=SriyvqmSDip4X4tOR/AkhHiCjWi+t8ldlMd5NPJPOdE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZAYtlx66Y2znA9TUJsGJiHn1E+aXuX58cBG00SXiNhcAugR0ANccckca5nZWd3Ud2 ncxUJydCeUldAPF+MfKVjbXZP8L0ovmpUoOs2CNY9xPSgNsLRBx5Hojoj1z7GrlUK6 540FhpKOZfTtCwLY+mqwTE3ktntKkVxVwWlse3xADk4MKcSY/uWf962q+TErfRwhNO UdB7tUVkR3a+MMDJ/sBndxYDTWCVPeKssT0kHRurwAB23MPZ7Ln8OCN5p7tkcIDsgL 9y5jWZ2ykYRrQlwCgWoXlKZAZrRJk0Z0GK4w2RDARxgJppfaJVdli49aXanqa0msIU kurjIvoY5EC1w== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4465980240; Sun, 9 Jun 2024 17:06:43 -0400 (EDT) Original-Received: from pastel (unknown [24.140.236.196]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1901E1203BC; Sun, 9 Jun 2024 17:06:43 -0400 (EDT) In-Reply-To: <1dc364dc-1a16-4de4-9372-767906494610@gutov.dev> (Dmitry Gutov's message of "Sun, 9 Jun 2024 23:38:57 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286981 Archived-At: > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index f62cb2566b2..144cda8cfdc 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -3816,7 +3816,7 @@ completion-basic-all-completions > 'point > (substring afterpoint 0 (cdr bounds))))) > (all (completion-pcm--all-completions prefix pattern table pred= ))) > - (completion-hilit-commonality all point (car bounds)))) > + (completion-pcm--hilit-commonality pattern all))) > > ;;; Partial-completion-mode style completion. Thanks for tracking it down. It matches my expectation. > But it would have been nice to be able to use it in the "progressive > improvement" kind of fashion: when the suffix and the other parts are > highlighted correctly, we do the right thing; if the style missed the > suffix highlighting, we do the other thing - and put the responsibility = on > the third party. =F0=9F=99=82 Stefan