From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: 7292@debbugs.gnu.org, Ryan Twitchell <metatheorem@gmail.com>
Subject: bug#7292: view-mode clobbers speedbar bindings
Date: Fri, 29 Oct 2010 12:00:30 -0400 [thread overview]
Message-ID: <jwvwrp12dri.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <yehbg5tp4m.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 29 Oct 2010 03:49:29 -0400")
>>> (I notice a few other files call toggle-read-only as well. Seems odd.)
>> A fair question. I suppose this is just caution: toggle-read-only will
>> always "do the right thing" to make sure the buffer is read-only, though
>> setting buffer-read-only should be sufficient.
> That doesn't make sense to me. I replace several inappropriate uses,
> including the speedbar one.
> I wonder if toggle-read-only should even be added to
> byte-compile-interactive-only-functions.
I wonder as well. I know I'm to blame for some of the calls to
toggle-read-only, because I thought it might be better to use the
higher-level function. But indeed it seems that was a mistake.
So let's add it to byte-compile-interactive-only-functions (with
a comment about why); and if it turns out that there are many cases
where calling it from Elisp makes sense, then we'll get to learn which
are the cases where it makes sense.
Stefan
next prev parent reply other threads:[~2010-10-29 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 0:03 bug#7292: view-mode clobbers speedbar bindings Ryan Twitchell
2010-10-28 3:01 ` Glenn Morris
2010-10-28 3:11 ` Ryan Twitchell
2010-10-29 7:49 ` Glenn Morris
2010-10-29 16:00 ` Stefan Monnier [this message]
2011-11-10 2:19 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwrp12dri.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=7292@debbugs.gnu.org \
--cc=metatheorem@gmail.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).