From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8184: 23.1.90; `menu-bar-non-minibuffer-window-p' error in calls to `kill-this-buffer' Date: Sun, 06 Mar 2011 14:53:31 -0500 Message-ID: References: <4D73D021.8070105@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1299446759 5042 80.91.229.12 (6 Mar 2011 21:25:59 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 6 Mar 2011 21:25:59 +0000 (UTC) Cc: 8184@debbugs.gnu.org, tlh To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 06 22:25:54 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PwLP2-0005Bs-1r for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Mar 2011 22:25:54 +0100 Original-Received: from localhost ([127.0.0.1]:47174 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PwLOJ-0000SH-G9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Mar 2011 16:21:27 -0500 Original-Received: from [140.186.70.92] (port=59732 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PwLHg-00050E-TH for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2011 16:14:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PwKEA-0007JL-9H for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2011 15:06:55 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PwKEA-0007JG-2t for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2011 15:06:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PwK1h-0001Qe-My; Sun, 06 Mar 2011 14:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Mar 2011 19:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8184 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8184-submit@debbugs.gnu.org id=B8184.12994412205466 (code B ref 8184); Sun, 06 Mar 2011 19:54:01 +0000 Original-Received: (at 8184) by debbugs.gnu.org; 6 Mar 2011 19:53:40 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PwK1L-0001Q7-Vj for submit@debbugs.gnu.org; Sun, 06 Mar 2011 14:53:40 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PwK1J-0001Pw-IG for 8184@debbugs.gnu.org; Sun, 06 Mar 2011 14:53:38 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAK50c03O+Lo//2dsb2JhbACmYHW9b4ViBIUcj3E X-IronPort-AV: E=Sophos;i="4.62,272,1297054800"; d="scan'208";a="94713218" Original-Received: from 206-248-186-63.dsl.teksavvy.com (HELO ceviche.home) ([206.248.186.63]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 06 Mar 2011 14:53:32 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id B3F83660D6; Sun, 6 Mar 2011 14:53:31 -0500 (EST) In-Reply-To: <4D73D021.8070105@gmx.at> (martin rudalics's message of "Sun, 06 Mar 2011 19:19:13 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 06 Mar 2011 14:54:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:44711 Archived-At: >> ??? This function is bound to the "Close" item in the "File" menu, so >> it is definitely related to the menu bar. > Am I right that the time for executing `kill-this-buffer-enabled-p' is > currently always proportional to the number of live buffers? In that > case I'd rewrite his function as > (defun kill-this-buffer-enabled-p () > (or (not (menu-bar-non-minibuffer-window-p)) > (let (found-1) > (catch 'found-2 > (dolist (buffer (buffer-list)) > (unless (string-match-p "^ " (buffer-name buffer)) > (if (not found-1) > (setq found-1 t) > (throw 'found-2 t)))))))) Probably a good change, yes. It'd also be good to add a comment explaining why we do this loop searching for some non-temp buffer. IIUC this function is used to check whether kill-this-buffer can do its job, and if (menu-bar-non-minibuffer-window-p) is nil, then we use abort-recursive-edit, so we need to check if abort-recursive-edit can be used, which seems related to minibuffer-depth rather than to non-temp buffers. Stefan