From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd Date: Tue, 08 Nov 2011 12:09:04 -0500 Message-ID: References: <1320754903.5597.30.camel@s1499.it.kth.se> <4EB95C65.2020404@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1320785954 9977 80.91.229.12 (8 Nov 2011 20:59:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 8 Nov 2011 20:59:14 +0000 (UTC) Cc: 9926@debbugs.gnu.org, srs@kth.se To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 08 21:59:10 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RNslC-0000TH-0l for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Nov 2011 21:59:10 +0100 Original-Received: from localhost ([::1]:50392 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNsl7-0001Lo-PD for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Nov 2011 15:59:05 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:56156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNsl4-0001LX-Fz for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2011 15:59:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNsl3-0002tf-GH for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2011 15:59:02 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNsl3-0002tb-Eo for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2011 15:59:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RNsl3-0006G3-Um for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2011 15:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2011 20:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9926-submit@debbugs.gnu.org id=B9926.132078593624046 (code B ref 9926); Tue, 08 Nov 2011 20:59:01 +0000 Original-Received: (at 9926) by debbugs.gnu.org; 8 Nov 2011 20:58:56 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNskx-0006Fl-JX for submit@debbugs.gnu.org; Tue, 08 Nov 2011 15:58:56 -0500 Original-Received: from harpie.cc.umontreal.ca ([132.204.2.134]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNskv-0006FV-9E for 9926@debbugs.gnu.org; Tue, 08 Nov 2011 15:58:54 -0500 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id pA8H95Ag013128; Tue, 8 Nov 2011 12:09:05 -0500 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id A05F9130090; Tue, 8 Nov 2011 12:09:04 -0500 (EST) In-Reply-To: <4EB95C65.2020404@cs.ucla.edu> (Paul Eggert's message of "Tue, 08 Nov 2011 08:44:21 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4035=0 X-NAI-Spam-Version: 2.2.0.9286 : core <4035> : streams <699570> : uri <1002563> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 08 Nov 2011 15:59:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:53721 Archived-At: > I don't see anything wrong with changing Emacs to use GC_MAKE_GCPROS_NOOPS > on GNU/Hurd. If there's no objection I would like to install the change > suggested by Stefan, which should have the same effect as patching gnu.h > but results in cleaner code internally. Please see the patch below. I'd rather keep the old default for now and change it in 24.2, only. So I'd rather use the OP's patch that only affects the Hurd. > === modified file 'src/s/ms-w32.h' > --- src/s/ms-w32.h 2011-11-05 16:30:13 +0000 > +++ src/s/ms-w32.h 2011-11-08 16:29:11 +0000 > @@ -402,5 +402,8 @@ > #define DebPrint(stuff) > #endif > +/* Conservative garbage collection has not been tested, so for now > + play it safe and stick with the old-fashioned way of marking. */ > +#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE Really? This sounds wrong, Stefan