From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 9926@debbugs.gnu.org, srs@kth.se
Subject: bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd
Date: Tue, 08 Nov 2011 12:09:04 -0500 [thread overview]
Message-ID: <jwvwrba7dbp.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4EB95C65.2020404@cs.ucla.edu> (Paul Eggert's message of "Tue, 08 Nov 2011 08:44:21 -0800")
> I don't see anything wrong with changing Emacs to use GC_MAKE_GCPROS_NOOPS
> on GNU/Hurd. If there's no objection I would like to install the change
> suggested by Stefan, which should have the same effect as patching gnu.h
> but results in cleaner code internally. Please see the patch below.
I'd rather keep the old default for now and change it in 24.2, only.
So I'd rather use the OP's patch that only affects the Hurd.
> === modified file 'src/s/ms-w32.h'
> --- src/s/ms-w32.h 2011-11-05 16:30:13 +0000
> +++ src/s/ms-w32.h 2011-11-08 16:29:11 +0000
> @@ -402,5 +402,8 @@
> #define DebPrint(stuff)
> #endif
> +/* Conservative garbage collection has not been tested, so for now
> + play it safe and stick with the old-fashioned way of marking. */
> +#define GC_MARK_STACK GC_USE_GCPROS_AS_BEFORE
Really? This sounds wrong,
Stefan
next prev parent reply other threads:[~2011-11-08 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 22:54 bug#9926: patch: emacs-24.0.91 FTBFS on GNU/Hurd Svante Signell
2011-11-01 17:42 ` Stefan Monnier
2011-11-07 5:43 ` Paul Eggert
2011-11-08 12:21 ` Svante Signell
2011-11-08 13:31 ` Stefan Monnier
2011-11-08 16:44 ` Paul Eggert
2011-11-08 17:09 ` Stefan Monnier [this message]
2011-11-08 20:18 ` Paul Eggert
2011-11-08 17:23 ` Eli Zaretskii
2011-11-08 20:36 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwrba7dbp.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=9926@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=srs@kth.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).