From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13549: 24.3.50; FR: Improve grep output (show function names, when possible) Date: Fri, 25 Jan 2013 13:55:08 -0500 Message-ID: References: <87a9rxux7q.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1359198661 15540 80.91.229.3 (26 Jan 2013 11:11:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 26 Jan 2013 11:11:01 +0000 (UTC) Cc: 13549@debbugs.gnu.org To: Jambunathan K Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 26 12:11:18 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tz3fF-0002a1-5F for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Jan 2013 12:11:13 +0100 Original-Received: from localhost ([::1]:51145 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tz3ew-0008WM-Tj for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Jan 2013 06:10:54 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tz3es-0008WA-GZ for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 06:10:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tz3er-0002GJ-6h for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 06:10:50 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tz3er-0002GF-33 for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 06:10:49 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tz3f4-0005d8-6t for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 06:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Jan 2013 11:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13549 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.135919865421617 (code B ref -1); Sat, 26 Jan 2013 11:11:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Jan 2013 11:10:54 +0000 Original-Received: from localhost ([127.0.0.1]:50047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tz3ev-0005cb-KK for submit@debbugs.gnu.org; Sat, 26 Jan 2013 06:10:54 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52153) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tz3es-0005cU-Vs for submit@debbugs.gnu.org; Sat, 26 Jan 2013 06:10:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tz3ee-0002B7-NZ for submit@debbugs.gnu.org; Sat, 26 Jan 2013 06:10:37 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:60720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tz3ee-0002B3-KD for submit@debbugs.gnu.org; Sat, 26 Jan 2013 06:10:36 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tz3ec-0008W1-Tq for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 06:10:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tz3eb-0002AS-AW for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 06:10:34 -0500 Original-Received: from smtp205.alice.it ([82.57.200.101]:52668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tz3eb-0002AH-01 for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 06:10:33 -0500 Original-Received: from fmsmemgm.homelinux.net (82.107.57.105) by smtp205.alice.it (8.6.058.01) id 50AA072A0A510014 for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 12:10:32 +0100 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 45109AE3F4; Sat, 26 Jan 2013 06:10:31 -0500 (EST) Resent-Message-ID: Resent-To: bug-gnu-emacs@gnu.org Resent-From: Stefan Monnier Resent-Date: Sat, 26 Jan 2013 06:10:31 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 29F00AE519; Fri, 25 Jan 2013 13:55:08 -0500 (EST) In-Reply-To: <87a9rxux7q.fsf@gmail.com> (Jambunathan K.'s message of "Fri, 25 Jan 2013 20:27:29 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70333 Archived-At: > I used the following local modification to compile.el to sneak in the > function names. > The modification is in `compilation-parse-errors' which seems to be a > font-lock handler. It's not quite a font-lock handler: it's a function that can get called to parse errors when needed. It is triggered by font-lock, indeed, but also by next-error (e.g. tho often font-lock will have done the work of parsing already). > I call `which-function' within this context. Is it justified? I'm not sure what you mean by "justified", but I see no particular reason why it shouldn't work. Your suggestion is interesting, and clearly since it is specific to `grep' it should be moved to grep.el (maybe as a font-lock-keyword?). It would need to be an option, since for some uses it doesn't make much sense (especially considering the performance impact it can have, and the amount of screen real-estate it requires). Stefan