From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14434: 24.3; lisp mode's comment start seems bad Date: Wed, 22 May 2013 17:32:14 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1369258411 1026 80.91.229.3 (22 May 2013 21:33:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 May 2013 21:33:31 +0000 (UTC) Cc: 14434@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 22 23:33:30 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UfGf3-0002Qj-1B for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2013 23:33:29 +0200 Original-Received: from localhost ([::1]:55855 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfGf2-0008VD-Bw for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2013 17:33:28 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfGev-0008Uv-8s for bug-gnu-emacs@gnu.org; Wed, 22 May 2013 17:33:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfGeq-0000nf-DX for bug-gnu-emacs@gnu.org; Wed, 22 May 2013 17:33:21 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfGeq-0000mt-AZ for bug-gnu-emacs@gnu.org; Wed, 22 May 2013 17:33:16 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UfGfZ-0003bq-SR for bug-gnu-emacs@gnu.org; Wed, 22 May 2013 17:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 May 2013 21:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14434 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14434-submit@debbugs.gnu.org id=B14434.136925838413771 (code B ref 14434); Wed, 22 May 2013 21:34:01 +0000 Original-Received: (at 14434) by debbugs.gnu.org; 22 May 2013 21:33:04 +0000 Original-Received: from localhost ([127.0.0.1]:56825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UfGed-0003a3-10 for submit@debbugs.gnu.org; Wed, 22 May 2013 17:33:03 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:45737) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UfGea-0003Zb-RA for 14434@debbugs.gnu.org; Wed, 22 May 2013 17:33:01 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r4MLWENB000491; Wed, 22 May 2013 17:32:14 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 16902B4030; Wed, 22 May 2013 17:32:14 -0400 (EDT) In-Reply-To: (Leo Liu's message of "Wed, 22 May 2013 12:26:24 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4587=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4587> : streams <965636> : uri <1427382> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74465 Archived-At: > After fixing bug#14303, we can observe the following bug: > 1. Emacs -q > 2. insert in a emacs lisp mode buffer: > ( > ;; > ) > 3. Move point to be end of ;; > 4. M-j > You should see: > ( > ;; > ; > ) > This seems to be due to bad comment-start-skip. That's one way to see it. Another is that it's a regression introduced by the fix to bug#14303. It probably affects more than emacs-lisp-mode. So it'd be better to fix it by improving your fix to bug#14303. E.g. after the new while loop which finds the comment start, do a looking-at to make sure the match-data extends as far as possible. Tho maybe, we should take a new look at bug#14303 to see why it failed, since after all the old comment-search-backward did already pay attention to comment-use-global-state (via comment-search-forward), so maybe bug#14303 was really due to a bug in comment-search-forward. Stefan