* bug#15447: (quail-help "korean-hangul") generates errors.
@ 2013-09-22 9:53 crocket
2013-09-24 6:25 ` Eli Zaretskii
2013-09-25 13:29 ` Kenichi Handa
0 siblings, 2 replies; 9+ messages in thread
From: crocket @ 2013-09-22 9:53 UTC (permalink / raw)
To: 15447
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
The error trace is shown below.
Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil)
quail-help("korean-hangul")
eval((quail-help "korean-hangul") nil)
eval-last-sexp-1(t)
eval-last-sexp(t)
eval-print-last-sexp()
call-interactively(eval-print-last-sexp nil nil)
recursive-edit()
debug(error (wrong-type-argument char-or-string-p nil))
quail-help("korean-hangul")
eval((quail-help "korean-hangul") nil)
eval-last-sexp-1(t)
eval-last-sexp(t)
eval-print-last-sexp()
call-interactively(eval-print-last-sexp nil nil)
recursive-edit()
debug(error (void-function quail-help))
(quail-help "korean-hangul")
eval((quail-help "korean-hangul") nil)
eval-last-sexp-1(t)
eval-last-sexp(t)
eval-print-last-sexp()
call-interactively(eval-print-last-sexp nil nil)
recursive-edit()
debug(error (void-function quail-help))
(quail-help (quote korean-hangul))
eval((quail-help (quote korean-hangul)) nil)
eval-last-sexp-1(t)
eval-last-sexp(t)
eval-print-last-sexp()
call-interactively(eval-print-last-sexp nil nil)
[-- Attachment #2: Type: text/html, Size: 1502 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#15447: (quail-help "korean-hangul") generates errors.
2013-09-22 9:53 bug#15447: (quail-help "korean-hangul") generates errors crocket
@ 2013-09-24 6:25 ` Eli Zaretskii
[not found] ` <CAL0=0H1DhNtGViH8YFnjJ9MUvicOhNHbspH9iDW8iib==_oq2g@mail.gmail.com>
2013-09-25 13:29 ` Kenichi Handa
1 sibling, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2013-09-24 6:25 UTC (permalink / raw)
To: crocket; +Cc: 15447
> Date: Sun, 22 Sep 2013 18:53:25 +0900
> From: crocket <crockabiscuit@gmail.com>
>
> The error trace is shown below.
>
> Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil)
> quail-help("korean-hangul")
quail-help gives help on quail _packages_, and korean-hangul is not a
package, it's an input method.
Try this instead:
C-u C-\ korean-hanja RET
C-\
M-: (quail-help "korean-hanja") RET
This works because korean-hanja is a Leim package.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#15447: (quail-help "korean-hangul") generates errors.
[not found] ` <CAL0=0H1DhNtGViH8YFnjJ9MUvicOhNHbspH9iDW8iib==_oq2g@mail.gmail.com>
@ 2013-09-24 20:32 ` Eli Zaretskii
2013-09-24 22:18 ` Stefan Monnier
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2013-09-24 20:32 UTC (permalink / raw)
To: crocket; +Cc: 15447
[Please keep the bug address on the CC list.]
> Date: Wed, 25 Sep 2013 05:18:49 +0900
> From: crocket <crockabiscuit@gmail.com>
>
> So, is it not a bug?
I don't think it is a bug, although it would be nicer if instead of
signaling an error Emacs would say something like "unknown package:
FOO".
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#15447: (quail-help "korean-hangul") generates errors.
2013-09-24 20:32 ` Eli Zaretskii
@ 2013-09-24 22:18 ` Stefan Monnier
2013-09-25 5:43 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2013-09-24 22:18 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 15447, crocket
>> So, is it not a bug?
> I don't think it is a bug, although it would be nicer if instead of
> signaling an error Emacs would say something like "unknown package:
> FOO".
I guess it also depends on how we end up calling quail-help.
After all, the user is not expected to type M-: (quail-help "foobar") RET.
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#15447: (quail-help "korean-hangul") generates errors.
2013-09-24 22:18 ` Stefan Monnier
@ 2013-09-25 5:43 ` Eli Zaretskii
2013-09-25 14:09 ` Kenichi Handa
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2013-09-25 5:43 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 15447, crockabiscuit
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: crocket <crockabiscuit@gmail.com>, 15447@debbugs.gnu.org
> Date: Tue, 24 Sep 2013 18:18:44 -0400
>
> >> So, is it not a bug?
> > I don't think it is a bug, although it would be nicer if instead of
> > signaling an error Emacs would say something like "unknown package:
> > FOO".
>
> I guess it also depends on how we end up calling quail-help.
> After all, the user is not expected to type M-: (quail-help "foobar") RET.
It's a command, but invoking it interactively yields the same
behavior. You need to have activated an input method that loads some
quail package, before invoking this command, in order to have a help.
korean-hangul doesn't load any quail package, so the command throws an
error.
So I still think a more human-readable error message is in order,
although when invoked interactively the package name is not given, so
some other wording is in order.
It looks like quail-help was designed to be called only by "C-h C-\",
where it behaves reasonably, but since it's a command, it perhaps
should have some minimal harness for when it is invoked by users
directly.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#15447: (quail-help "korean-hangul") generates errors.
2013-09-22 9:53 bug#15447: (quail-help "korean-hangul") generates errors crocket
2013-09-24 6:25 ` Eli Zaretskii
@ 2013-09-25 13:29 ` Kenichi Handa
1 sibling, 0 replies; 9+ messages in thread
From: Kenichi Handa @ 2013-09-25 13:29 UTC (permalink / raw)
To: crocket; +Cc: 15447
In article <CAL0=0H3qh1xfncjnfH92TZm5UCXVCSBouyaVe1E=QciLLD-Z-Q@mail.gmail.com>, crocket <crockabiscuit@gmail.com> writes:
> The error trace is shown below.
> Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil)
> quail-help("korean-hangul")
As these input methods are not "quail" input methods:
korean-hangul, korean-hangul3f, korean-hangul390, korean-hangul3,
ucs
quail-help doesn't work for them.
If you want to describe those input methods, do:
(describe-input-method "korean-hangul")
or, type "C-h C-\ korean hangul RET".
---
Kenichi Handa
handa@gnu.org
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#15447: (quail-help "korean-hangul") generates errors.
2013-09-25 5:43 ` Eli Zaretskii
@ 2013-09-25 14:09 ` Kenichi Handa
2013-09-25 17:07 ` Stefan Monnier
0 siblings, 1 reply; 9+ messages in thread
From: Kenichi Handa @ 2013-09-25 14:09 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 15447, crockabiscuit
In article <83li2lh2w1.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:
> It looks like quail-help was designed to be called only by "C-h C-\",
> where it behaves reasonably, but since it's a command, it perhaps
> should have some minimal harness for when it is invoked by users
> directly.
If it is ok to break a subtle backward compatibility here,
let's make quail-help not a command. It had to be a
command when I first implemented it, but now it doesn't have
to be. It is now called from describe-current-input-method
by funcall.
---
Kenichi Handa
handa@gnu.org
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#15447: (quail-help "korean-hangul") generates errors.
2013-09-25 14:09 ` Kenichi Handa
@ 2013-09-25 17:07 ` Stefan Monnier
2013-09-26 14:00 ` Kenichi Handa
0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2013-09-25 17:07 UTC (permalink / raw)
To: Kenichi Handa; +Cc: 15447, crockabiscuit
> If it is ok to break a subtle backward compatibility here,
> let's make quail-help not a command.
Fine by me,
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#15447: (quail-help "korean-hangul") generates errors.
2013-09-25 17:07 ` Stefan Monnier
@ 2013-09-26 14:00 ` Kenichi Handa
0 siblings, 0 replies; 9+ messages in thread
From: Kenichi Handa @ 2013-09-26 14:00 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 15447, crockabiscuit
In article <jwv7ge4x229.fsf-monnier+emacsbugs@gnu.org>, Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> > If it is ok to break a subtle backward compatibility here,
> > let's make quail-help not a command.
> Fine by me,
I've just committed that change.
---
Kenichi Handa
handa@gnu.org
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-09-26 14:00 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-22 9:53 bug#15447: (quail-help "korean-hangul") generates errors crocket
2013-09-24 6:25 ` Eli Zaretskii
[not found] ` <CAL0=0H1DhNtGViH8YFnjJ9MUvicOhNHbspH9iDW8iib==_oq2g@mail.gmail.com>
2013-09-24 20:32 ` Eli Zaretskii
2013-09-24 22:18 ` Stefan Monnier
2013-09-25 5:43 ` Eli Zaretskii
2013-09-25 14:09 ` Kenichi Handa
2013-09-25 17:07 ` Stefan Monnier
2013-09-26 14:00 ` Kenichi Handa
2013-09-25 13:29 ` Kenichi Handa
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).