From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Date: Tue, 05 Nov 2013 22:20:37 -0500 Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1383708080 27814 80.91.229.3 (6 Nov 2013 03:21:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Nov 2013 03:21:20 +0000 (UTC) Cc: 15814@debbugs.gnu.org To: Nathan Trapuzzano Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 06 04:21:23 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VdtgJ-0004TG-2H for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Nov 2013 04:21:23 +0100 Original-Received: from localhost ([::1]:59657 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdtgI-0003Yu-De for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Nov 2013 22:21:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdtg7-0003Nm-L3 for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 22:21:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vdtfz-00061U-Qw for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 22:21:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdtfz-00061N-Gv for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 22:21:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vdtfz-0006Yr-6A for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 22:21:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Nov 2013 03:21:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15814 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15814-submit@debbugs.gnu.org id=B15814.138370804725164 (code B ref 15814); Wed, 06 Nov 2013 03:21:03 +0000 Original-Received: (at 15814) by debbugs.gnu.org; 6 Nov 2013 03:20:47 +0000 Original-Received: from localhost ([127.0.0.1]:36424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdtfi-0006Xo-Ie for submit@debbugs.gnu.org; Tue, 05 Nov 2013 22:20:46 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:31208) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdtff-0006XZ-Ru for 15814@debbugs.gnu.org; Tue, 05 Nov 2013 22:20:44 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GsR+QDpEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GsR+QDpEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37193761" Original-Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 05 Nov 2013 22:20:37 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 8212F60A07; Tue, 5 Nov 2013 22:20:37 -0500 (EST) In-Reply-To: <87a9himfvp.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Tue, 05 Nov 2013 21:19:06 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80055 Archived-At: >> Good idea. Could you try and use macroexp--warn-and-return instead, so >> we get a file&line location when byte-compiling? > I'm not certain what you mean here. You seem to agree that this is an > error, but `macroexp--warn-and-return' doesn't signal an error--it just > prints a warning. If we do something like this: > (let ((msg (format "Malformed `cl-symbol-macrolet' binding: %S" > (car bindings)))) > (macroexp--warn-and-return msg `(error "%s" ,msg))) > we'll get a warning at compile time and an error at run time. Is this > what you have in mind? Shouldn't we signal the error as early as > possible? Perhaps there is some Emacs convention that I'm not aware of > in this regard. Signaling an error stops the whole compilation, so you only get one error at a time. Better make it a warning, even though it is indeed a programming error. >> BTW, the same holds for the "let" sanity checks you added to cconv >> (which should probably be moved to macroexp, now that I think about it, >> so we can remove them from bytecomp.el). > I don't understand this either. By "moved to macroexp", do you just > mean that the sanity checks should be performed using > macroexp--warn-and-return in the manner given above? No, I mean that they should be performed in macroexp--expand-all rather than in cconv, so they're performed regardless of lexical-binding (currently they're done once in cconv.el and once in bytecomp.el). Stefan