From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17235: Undo in region adjusts past positions incorrectly Date: Wed, 23 Apr 2014 13:56:14 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1398275850 10355 80.91.229.3 (23 Apr 2014 17:57:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Apr 2014 17:57:30 +0000 (UTC) Cc: 17235@debbugs.gnu.org To: Barry OReilly Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 23 19:57:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wd1Q9-0007gT-9U for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Apr 2014 19:57:21 +0200 Original-Received: from localhost ([::1]:34120 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wd1Q8-0003ig-Qy for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Apr 2014 13:57:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wd1Py-0003iG-PH for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 13:57:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wd1Pq-0000ln-Qd for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 13:57:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wd1Pq-0000lc-Nl for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 13:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wd1Pq-0004ka-8h for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 13:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Apr 2014 17:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17235-submit@debbugs.gnu.org id=B17235.139827577718176 (code B ref 17235); Wed, 23 Apr 2014 17:57:02 +0000 Original-Received: (at 17235) by debbugs.gnu.org; 23 Apr 2014 17:56:17 +0000 Original-Received: from localhost ([127.0.0.1]:56404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wd1P7-0004j6-5R for submit@debbugs.gnu.org; Wed, 23 Apr 2014 13:56:17 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:22688) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wd1P5-0004iy-E5 for 17235@debbugs.gnu.org; Wed, 23 Apr 2014 13:56:15 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNMCqOU/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBJy8jBQsLNBIUGA0kiAQI0hkXjhZkB4Q4AQOpGYFqg0whgSw X-IPAS-Result: ArUGAIDvNVNMCqOU/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBJy8jBQsLNBIUGA0kiAQI0hkXjhZkB4Q4AQOpGYFqg0whgSw X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="58715269" Original-Received: from 76-10-163-148.dsl.teksavvy.com (HELO pastel.home) ([76.10.163.148]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 23 Apr 2014 13:56:14 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 318AC6041B; Wed, 23 Apr 2014 13:56:14 -0400 (EDT) In-Reply-To: (Barry OReilly's message of "Wed, 23 Apr 2014 12:20:29 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88261 Archived-At: > I attached the patch implementing this. The new > undo-test-region-deletion test implements the recipe of this bug > report. It fails with the current undo-make-selective-list code, > passes with the new. Looks good. Please install into trunk. > Do you recall why the code ceases to make the selective list when an > element cross the region? No idea, I've never been very familiar with that code. My guess is that the author didn't know how to make it work correctly, or didn't want to go through the trouble of making it work correctly. > +;; More interesting is how to adjust the "ddd" insertion due to the > +;; next undo-delta: (6 . -2). If the reinsertion of "ad" was an undo, > +;; it is most sensical that the total "ddd" insertion adjustment be (7 > +;; . 10) -> (6 . 8) -> (7 . 10). However, if the reinsertion was a > +;; normal user edit, then most sensical is: (7 . 10) -> (6 . 8) -> (8 > +;; . 10). The undo history is ambiguous about which. I was not able to understand the above comment. Stefan