From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#21523: 25.0.50; Undo with active region adds extra text Date: Sun, 20 Sep 2015 11:14:29 -0400 Message-ID: References: <48592862-1630-4c61-aeed-1e3b720824de@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1442762130 31210 80.91.229.3 (20 Sep 2015 15:15:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Sep 2015 15:15:30 +0000 (UTC) Cc: 21523@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 20 17:15:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZdgKe-0007WK-Bx for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Sep 2015 17:15:12 +0200 Original-Received: from localhost ([::1]:52359 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdgKd-0007e8-R0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Sep 2015 11:15:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdgKZ-0007ci-Rx for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2015 11:15:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZdgKV-0000SW-SI for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2015 11:15:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdgKV-0000SE-Pt for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2015 11:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZdgKV-0002fq-9g for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2015 11:15:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Sep 2015 15:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21523-submit@debbugs.gnu.org id=B21523.144276207810231 (code B ref 21523); Sun, 20 Sep 2015 15:15:03 +0000 Original-Received: (at 21523) by debbugs.gnu.org; 20 Sep 2015 15:14:38 +0000 Original-Received: from localhost ([127.0.0.1]:38882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZdgK5-0002ew-O0 for submit@debbugs.gnu.org; Sun, 20 Sep 2015 11:14:37 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:25046) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZdgK3-0002eo-Uu for 21523@debbugs.gnu.org; Sun, 20 Sep 2015 11:14:36 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BCFgA731xV/2yixEVcgxCEAoVVwD6CTQQCAoE8PRABAQEBAQEBgQpBBYNdAQEEViMQCzQSFBgNJIg/zyMBAQEBAQUCAR+LOoUFB4QtBbM/gUUjhBQigngBAQE X-IPAS-Result: A0BCFgA731xV/2yixEVcgxCEAoVVwD6CTQQCAoE8PRABAQEBAQEBgQpBBYNdAQEEViMQCzQSFBgNJIg/zyMBAQEBAQUCAR+LOoUFB4QtBbM/gUUjhBQigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="165370094" Original-Received: from 69-196-162-108.dsl.teksavvy.com (HELO ceviche.home) ([69.196.162.108]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 20 Sep 2015 11:14:35 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id DEAD56614D; Sun, 20 Sep 2015 11:14:29 -0400 (EDT) In-Reply-To: <48592862-1630-4c61-aeed-1e3b720824de@default> (Drew Adams's message of "Sun, 20 Sep 2015 00:34:06 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106730 Archived-At: > `C-_' to undo the last change within the region. > The word "that" is inserted, giving this: > ;; then enter the text in Thatthat file's own buffer. > This seems disconcerting, at least. (Same behavior for `M-u' etc.) Indeed, that's wrong. I haven't looked in detail of why this happens, but I can guess that it's because the previous change is represented as "insert That" and "remove that", and when we undo them, the exact location of "remove that" ends up right at the region boundary, making it unclear whether it should be considered as "inside" or "outside". Not sure how best to fix it. Maybe such replacements should have a special status in the undo-list, so they aren't considered as two independent changes (remove+insert) but as a single one. Or maybe the "undo-in-region" should only ever undo complete steps (i.e. everything between two undo boundaries), so if any part of an undo step affects text outside of the region, then the whole step is skipped. Stefan