From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#42149: Substring and flex completion ignore implicit trailing =?UTF-8?Q?=E2=80=98any=E2=80=99?= Date: Wed, 09 Sep 2020 09:13:29 -0400 Message-ID: References: <87k0znsdjb.fsf@gmail.com> <87sgbsv7gg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4989"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42149@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Dario Gjorgjevski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 09 15:14:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFzvP-0001AY-8X for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Sep 2020 15:14:11 +0200 Original-Received: from localhost ([::1]:53730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFzvO-00013N-82 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Sep 2020 09:14:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFzvG-00010E-UP for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2020 09:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46293) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFzvG-0003IG-Kb for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2020 09:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFzvG-0007D8-FQ for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2020 09:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Sep 2020 13:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42149-submit@debbugs.gnu.org id=B42149.159965722127681 (code B ref 42149); Wed, 09 Sep 2020 13:14:02 +0000 Original-Received: (at 42149) by debbugs.gnu.org; 9 Sep 2020 13:13:41 +0000 Original-Received: from localhost ([127.0.0.1]:57839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFzuu-0007CP-O4 for submit@debbugs.gnu.org; Wed, 09 Sep 2020 09:13:41 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFzur-0007CC-SQ for 42149@debbugs.gnu.org; Wed, 09 Sep 2020 09:13:39 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3857F805F3; Wed, 9 Sep 2020 09:13:32 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8BD298025A; Wed, 9 Sep 2020 09:13:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599657210; bh=zEagamj7KMb1xGxSofv6bpKtz3pGGlp5RFG/gGa1DHs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OhETjldkRaSBO2yUaTvWehXi3Yu4VjPYZl1S+GWNXfOXIW2MgVO7cAy9Ok6k9oHnr 6D7Xxjs00qZ9/WzxWvso5J/Xy+JZxPdqCWsg6esSPN2t80PBMeaaBIlOvqbEe8/fpt FuqxEOPCwklX5PlkwCS3rY0q5ohQDhdLVXuIgzXJnVasC8hqrfTgtRlPIPUgU4Agfj Kes6dFpbbjDPXI5FI+GlwboHQuzzQvI1Vlm0U8C95LVT2RYHcJhTIF13bD7NLlMb8g tAJVSU9DWBIcJi7VulSCanJfepvH4l7o3T0Lz1hUwqPWjfd8hvswmGANh5jelErLoP sOOW8w0ujAzIg== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4B1131206E3; Wed, 9 Sep 2020 09:13:30 -0400 (EDT) In-Reply-To: (Dario Gjorgjevski's message of "Wed, 09 Sep 2020 13:38:02 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187645 Archived-At: > Unfortunately, I found some bugs in the patch I shared above. While it > works well for substring and flex completion (with the minor caveat of > ignoring the point=E2=80=99s position which I will take care of), it brea= ks > under vanilla PCM completion. I will try to fix it. BTW, this code sorely needs tests, so when you find a bug (either in the original code or in changes you introduced temporarily), if you could add corresponding tests, that would be a great help. Stefan "yes, the very one to blame for the lack of those tests"