From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#34765: 26.1; with-temp-buffer should not run buffer-list-update-hook Date: Fri, 18 Dec 2020 10:36:22 -0500 Message-ID: References: <5C7FD591.9090505@gmx.at> <83lg1sc8ob.fsf@gnu.org> <5C8009F3.5000405@gmx.at> <767e1b59-6ac2-cd11-076e-82a56ac53e29@gmx.at> <11be4631-b087-52a3-92fe-4cbd5248908d@gmx.at> <838svxxk41.fsf@gnu.org> <49c11920-0909-dcc2-4a39-4cdcfaf20453@gmx.at> <87h7sp1xay.fsf@gnus.org> <83r1rgpusx.fsf@gnu.org> <87pn5u7m0y.fsf@gnus.org> <5bdc73dd-af73-1b9a-9bb4-e154787e1976@gmx.at> <87a6uzan9s.fsf@tcd.ie> <71b78484-b0a7-3e0e-a999-afa07f8b4832@gmx.at> <87lfeioh0v.fsf@tcd.ie> <83tut6iqbp.fsf@gnu.org> <87360qoa6o.fsf@tcd.ie> <878sa9cle0.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27339"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 34765@debbugs.gnu.org, larsi@gnus.org, alexanderm@web.de To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 18 16:53:02 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqI3y-0006zJ-Ai for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Dec 2020 16:53:02 +0100 Original-Received: from localhost ([::1]:57380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqI3x-0003oY-Ax for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Dec 2020 10:53:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqHoU-0005kV-LX for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 10:37:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56357) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqHoU-0005At-Do for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 10:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kqHoU-0004og-A0 for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 10:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Dec 2020 15:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34765 X-GNU-PR-Package: emacs Original-Received: via spool by 34765-submit@debbugs.gnu.org id=B34765.160830579318476 (code B ref 34765); Fri, 18 Dec 2020 15:37:02 +0000 Original-Received: (at 34765) by debbugs.gnu.org; 18 Dec 2020 15:36:33 +0000 Original-Received: from localhost ([127.0.0.1]:39670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHo0-0004nw-PF for submit@debbugs.gnu.org; Fri, 18 Dec 2020 10:36:32 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHny-0004ni-BO for 34765@debbugs.gnu.org; Fri, 18 Dec 2020 10:36:31 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0C8E210022E; Fri, 18 Dec 2020 10:36:25 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 904D9100018; Fri, 18 Dec 2020 10:36:23 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1608305783; bh=R5Ag/7oNxu7+I19SjOXpAXdh0c7tPpLo7I8Ez4MTcS0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZcjfJTQ4gvqWdblLE8ddoubEc2i67LAY8+C4YnWTZHSghqOl2ViEW/lNvRTy0U4Id v9ghvjPPSt9ZTP/LB5wiI4Sncfx5D+wgO8Sl1fn9Az+SEOjLuRZ5FTqONJyqMais8I VAnXz4r1FidSD9MBwLZrrwDvuZQkW8oXW5qSFZXCbbqQFkxG4cEkPYblnZ++nkK5ON c4O9keJUzmLUikAm+bKaUIx3qQ1HFKlt+apDozEJef3glkpVuNWf9iwOvtqJYnAjEj c6DskDuT7J88kKlCCtmWCpGCYYN+B8/1OlEM+00wfKTdu6A7ObzhmjuCv7HPfFwvo8 fbvJ5Sxb9JesA== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 44DA512030D; Fri, 18 Dec 2020 10:36:23 -0500 (EST) In-Reply-To: <878sa9cle0.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 07 Dec 2020 22:16:23 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196332 Archived-At: > (defmacro with-temp-file (file &rest body) > "Create a new buffer, evaluate BODY there, and write the buffer to FILE. > The value returned is the value of the last form in BODY. > -See also `with-temp-buffer'." > +The buffer is created using `with-temp-buffer', which see." > (declare (indent 1) (debug t)) > - (let ((temp-file (make-symbol "temp-file")) > - (temp-buffer (make-symbol "temp-buffer"))) > - `(let ((,temp-file ,file) > - (,temp-buffer (generate-new-buffer " *temp file*"))) > - (unwind-protect > - (prog1 > - (with-current-buffer ,temp-buffer > - ,@body) > - (with-current-buffer ,temp-buffer > - (write-region nil nil ,temp-file nil 0))) > - (and (buffer-name ,temp-buffer) > - (kill-buffer ,temp-buffer)))))) > + `(with-temp-buffer > + (prog1 (progn ,@body) > + (write-region nil nil ,file nil 0)))) You lost the `(with-current-buffer ,temp-buffer` around `write-region` so your new code will break if `body` doesn't preserve current-buffer. Stefan