From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation Date: Sat, 27 Feb 2021 16:00:21 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6349"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46819@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 27 22:01:38 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lG6iX-0001bV-TM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Feb 2021 22:01:37 +0100 Original-Received: from localhost ([::1]:43882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lG6iW-0002C7-Uu for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Feb 2021 16:01:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG6hy-0001vm-G6 for bug-gnu-emacs@gnu.org; Sat, 27 Feb 2021 16:01:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33913) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lG6hx-0006Nt-Oa for bug-gnu-emacs@gnu.org; Sat, 27 Feb 2021 16:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lG6hx-0007T4-OH for bug-gnu-emacs@gnu.org; Sat, 27 Feb 2021 16:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Feb 2021 21:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46819 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.161445963528669 (code B ref -1); Sat, 27 Feb 2021 21:01:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Feb 2021 21:00:35 +0000 Original-Received: from localhost ([127.0.0.1]:45459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG6hX-0007SL-L8 for submit@debbugs.gnu.org; Sat, 27 Feb 2021 16:00:35 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:44950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG6hR-0007S8-PD for submit@debbugs.gnu.org; Sat, 27 Feb 2021 16:00:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG6hR-0001nd-Cc for bug-gnu-emacs@gnu.org; Sat, 27 Feb 2021 16:00:29 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG6hM-00063V-MS for bug-gnu-emacs@gnu.org; Sat, 27 Feb 2021 16:00:28 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 67255441B5F; Sat, 27 Feb 2021 16:00:23 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 21F6D441AF6; Sat, 27 Feb 2021 16:00:22 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614459622; bh=eQda/HQymrrqehezT9YgM4NRgaB5Cow/XY+r/AZjIR8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DjAtil6s/y3aE/1I96DKJ0OQbIogJ6ySyn/7wGCFxB0FLXH6NCsgl5ufrkGgEtK5S ThS3AD/Vjhh+IKNIT+Zrpbgpa3gZaVZnaSUj1CX56UbWQuKPFYaOaXGULtHowZLqYd CbfvzQfX/s2x7Bp5rOr3A9tg+wtpdw7DXanKBEM68vc3sssUSYQWP3Jc4RYgdNiWMA N7/xs6FAlCBX1VOsIN1CIiqYfJfYvVVBIzcBRoUPd3ZwsAFJxoS6hRPQUVELFFG3lE m6tfcx7p8S0+BhfztHDfXahnpik1YNb8vh9Q1KLh/H2Pm7zIBuhyri9fKf9648VtJZ D/A0VbyLSA9gQ== Original-Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 33D451203C4; Sat, 27 Feb 2021 16:00:22 -0500 (EST) In-Reply-To: (Matt Armstrong's message of "Sat, 27 Feb 2021 12:18:56 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200986 Archived-At: > This behavior began with Stefan's recent commit d41a4ad4ae (* > lisp/emacs-lisp/macroexp.el ;; (macroexp--expand-all): Warn on empty let > bodies, 2021-02-15) > > `benchmark-run' has a timing `doloop' with an empty body, which `doloop` > expands to a `let` with an empty body (in the lexical-binding case). It'd be easy to put an explicit nil in the loop's body, but.... The idea was that in actual (non-macroexpanded) source code, empty let bodies are usually the result of a misplaced paren. But it's probably more often annoying than useful since we can't easily distinguish a "let from source code" from a "let from a macro expansion". So I'm also voting to revert that change. Any objection? Stefan