From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Date: Wed, 05 May 2021 10:05:22 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30506"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Gregory Heytings , 48153@debbugs.gnu.org To: Jimmy Yuen Ho Wong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 16:07:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leIBU-0007o0-L2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 16:07:28 +0200 Original-Received: from localhost ([::1]:51862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leIBT-000152-I4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 10:07:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leIA5-00007p-Uk for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 10:06:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48917) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leIA5-00019H-Mz for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 10:06:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leIA5-00049B-IX for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 10:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 14:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162022353215928 (code B ref 48153); Wed, 05 May 2021 14:06:01 +0000 Original-Received: (at 48153) by debbugs.gnu.org; 5 May 2021 14:05:32 +0000 Original-Received: from localhost ([127.0.0.1]:60460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leI9b-00048q-Ss for submit@debbugs.gnu.org; Wed, 05 May 2021 10:05:32 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leI9a-00048k-M1 for 48153@debbugs.gnu.org; Wed, 05 May 2021 10:05:31 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0A7F81001FB; Wed, 5 May 2021 10:05:25 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 24CBD10019F; Wed, 5 May 2021 10:05:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1620223523; bh=sVdLuBd4I5jTKqsHFRpgflFDIq68AxHZeZEZmBwjnKU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HPRacr9lxhDP3vjeTs68N2bu3KY3EcPwIAkX4zdysBt9S67WMFOwPiihz+iR67XWO WzhdtLIGB3bbaECfogzKEb5oEYH7SjzMU0JgwybjZqweUDIQTW+wgqGDuppUaeOPlh PlJlntYNkpdUQirXb9b/aGQEUhW3Z/0ocJEXLGMpB8xUe1Sea3U4mqKxhbESCDlg4d 4OhQZW10O4aLx2f8Y65N+MsrJEL/5mkOO8fuvfzbCH+ezn4Tva6fEBG7JIgOt/oFyg 8uR1O4AweJ3ldfx2xwJC8LjmFfcUfAKVvCC1KiDLb/GkzQLDEpj55mnDjVH4nNncYA 9GNzfA+2REH0g== Original-Received: from alfajor (76-10-140-76.dsl.teksavvy.com [76.10.140.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E85FE1201B5; Wed, 5 May 2021 10:05:22 -0400 (EDT) In-Reply-To: (Jimmy Yuen Ho Wong's message of "Tue, 4 May 2021 13:53:10 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205700 Archived-At: > Sorry I missed a reproduction step. You have to turn on the minor mode for > the minibuffers. In my config there actually is a global minor mode that > turns the minor mode on even for the minibuffer. > > In Emacs 27, turning the minor mode on inside the minibuffer would not > override the key map given to read-from-minibuffer. It would have helped to provide a precise recipe to start with, but indeed there's been a change in Emacs-28, in that the minibuffer now is setup in its own major mode, which may have the side-effect of enabling the buffer-local minor modes made global via `define-globalized-minor-mode` in some cases where this didn't happen before. [ I consider this change as a bug-fix. ] Note that `define-globalized-minor-mode` distinguishes between its MODE argument and the TURN-ON function specifically so that the mode can be enabled only in those buffers where it makes sense. So if your globalized minor mode shouldn't be used in minibuffers, you need to tweak its TURN-ON such that it tests `minibufferp` like in Gregory's example. > Because the minibuffer does not behave like any other buffers. Setting > `minor-mode-overriding-map-alist` has no effect, so I think either the I can't think of any reason why that would be the case. Do you have a simple test case (your `ido-resurrect-keybinding` is too complex for my little brain to understand what it's expected to do). Stefan