From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49809: [PATCH] Add macro 'pcase-setq' Date: Sat, 07 Aug 2021 11:42:09 -0400 Message-ID: References: <07ad5892-3343-4c35-00e3-9753bca5f67b@protonmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22242"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49809@debbugs.gnu.org To: Okam Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 07 17:43:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mCOTr-0005az-LF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Aug 2021 17:43:23 +0200 Original-Received: from localhost ([::1]:51076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCOTq-0006P6-CS for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Aug 2021 11:43:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCOTX-000614-4E for bug-gnu-emacs@gnu.org; Sat, 07 Aug 2021 11:43:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41487) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mCOTW-0000WE-KS for bug-gnu-emacs@gnu.org; Sat, 07 Aug 2021 11:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mCOTW-0000cJ-DM for bug-gnu-emacs@gnu.org; Sat, 07 Aug 2021 11:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Aug 2021 15:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49809-submit@debbugs.gnu.org id=B49809.16283509412292 (code B ref 49809); Sat, 07 Aug 2021 15:43:02 +0000 Original-Received: (at 49809) by debbugs.gnu.org; 7 Aug 2021 15:42:21 +0000 Original-Received: from localhost ([127.0.0.1]:53032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCOSr-0000at-3c for submit@debbugs.gnu.org; Sat, 07 Aug 2021 11:42:21 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCOSn-0000ad-Tw for 49809@debbugs.gnu.org; Sat, 07 Aug 2021 11:42:20 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 812DF440806; Sat, 7 Aug 2021 11:42:11 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 482024407A2; Sat, 7 Aug 2021 11:42:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1628350930; bh=z7BneETzmqIct1LHBh3JW3Dqdy0wIt7E0lJevjfsPOE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=knwtzC/Vu9cva/+hVJVL7gT7QGukXe5Qh07+rge43kEihpxflp8VqcQLyvySfjGGM paEjA1KSt9u/yl660mL/uyMQvBT3CmALQXB4xq6kuvTyUms3WW0a6pUcFTmqs72v4s a9LXtZF8HhG1Fu8XhgV7Lk1Lg63GT32lL/nrF6Lba/v1WHcyjaUjO7nwUKgHxo6ZQX S1vpPiKy74ejUdWOzzEERyTAIi8y+jkYjwRuRke0fQBXhW3PfATXMpP9c0bZ0VlrFT 6n1GX1NGF/7VNB5VcSNGzYZGrrhiZex8BsReWJtesBgnCuO3KTxoCyQ5u4u2g+Ld0+ yKmsPsfHvfn4A== Original-Received: from alfajor (unknown [216.154.29.138]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EDC8B1203D8; Sat, 7 Aug 2021 11:42:09 -0400 (EDT) In-Reply-To: (Okam's message of "Fri, 06 Aug 2021 22:33:36 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211382 Archived-At: > Added with others. Do you think that the added tests are sufficient? The new code looks OK to me. Just one thing, tho: > + (should (equal (list nil nil) > + (let (a b) > + (pcase-setq `(,a ,b) nil) > + (list a b)))) The result is the same whether `pcase-setq` assigns nil or doesn't touch the vars, so this test is not very effective. I'd rather do: (should (equal (list nil nil) (let ((a 'unset) (b 'unset)) (pcase-setq `(,a ,b) nil) (list a b)))) But Michael points out that it seems your code won't perform the assignment if the pattern doesn't match, which I find to be an odd behavior. I'd expect a behavior like that of `pcase-let`, instead. Stefan