From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Ken Hori <fplemma@gmail.com>, 6892@debbugs.gnu.org
Subject: bug#6892: Please add a way to jump to advices
Date: Mon, 09 May 2022 12:50:22 -0400 [thread overview]
Message-ID: <jwvwneups9q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87zgjq3bfz.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 09 May 2022 18:41:52 +0200")
> (I'm going through old bug reports that unfortunately weren't resolved
> at the time.)
>
> This seems to still be the case with advice-add:
>
> (defun bar ()
> (interactive)
> (forward-line 1))
>
> (advice-add 'bar :before (lambda () (forward-line 1)))
But it should work if you do
(advice-add 'bar :before #'bar--skip-line)
(defun bar--skip-line () (forward-line 1))
> I'm sure this has come up before -- does advice add no pointers (to
> load-history, I guess?) that the help system could pick up?
`define-advice` could, but `advice-add` is definitely not limited to
uses at top-level, so it shouldn't mess with `load-history`.
Stefan
next prev parent reply other threads:[~2022-05-09 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 18:17 bug#6892: Please add a way to jump to advices Ken Hori
2022-05-09 16:41 ` Lars Ingebrigtsen
2022-05-09 16:50 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-05-10 2:01 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwneups9q.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=6892@debbugs.gnu.org \
--cc=fplemma@gmail.com \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).