unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: 56613@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#56613: 29; minibuffer-complete-history throws an error for minibuffer-history-variable=t
Date: Mon, 18 Jul 2022 11:04:34 -0400	[thread overview]
Message-ID: <jwvwncah3bg.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <1a0674ad-8201-e707-5992-ddfaca9ab558@daniel-mendler.de> (Daniel Mendler's message of "Mon, 18 Jul 2022 09:41:09 +0200")

> Doesn't it work if you retrieve the boundaries first with
> `completion-boundaries` from `minibuffer-completion-table`? In my
> Vertico package I use the following code and it works without issues
> with CRM. The API requires a little bit of a ceremony.

I suspect it won't work correctly when CRM is used with a completion
table that itself uses boundaries (e.g. when completing a list of file
names).

It's quite unusual, so in practice your approach probably works fine,
but fundamentally I think it's "wrong" (tho I don't have much better to
offer right now, except by adding CRM-specific hacks).


        Stefan






  reply	other threads:[~2022-07-18 15:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-17 11:41 bug#56613: 29; minibuffer-complete-history throws an error for minibuffer-history-variable=t Daniel Mendler
2022-07-17 14:43 ` Drew Adams
2022-07-17 14:53   ` Daniel Mendler
2022-07-17 15:32     ` Drew Adams
2022-07-17 18:07 ` Juri Linkov
2022-07-17 20:10   ` Daniel Mendler
2022-07-18  7:24     ` Juri Linkov
2022-07-18  7:41       ` Daniel Mendler
2022-07-18 15:04         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-07-18 15:21           ` Daniel Mendler
2022-07-18 15:01       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-18 15:39         ` Daniel Mendler
2022-07-18 16:19           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-18 17:27             ` Daniel Mendler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvwncah3bg.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=56613@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=mail@daniel-mendler.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).