bug#62189: 29.0.60; complete-symbol while inside add-to-list form prints a warning

bug#62189: 29.0.60; complete-symbol while inside add-to-list form prints a warning

[Spencer Baugh]

1. Start emacs -Q and switch to *scratch*
2. Type (add-to-list f
3. Hit C-M-i to run complete-symbol
4. Observe the following warning and error in the *Messages* buffer:
Warning: Optimization failure for add-to-list: Handler: add-to-list--anon-cmacro
(wrong-number-of-arguments (3 . 5) 2)

This also occurs in Emacs 28 and 27.


In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2023-03-13 built on
 igm-qws-u22796a
Repository revision: e759905d2e0828eac4c8164b09113b40f6899656
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: CentOS Linux 7 (Core)

Configured using:
 'configure --with-x-toolkit=lucid --with-modules
 --with-gif=ifavailable'

Configured features:
CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND
SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM LUCID
ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Messages

Minor modes in effect:
  shell-dirtrack-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils sh-script rx smie treesit
cl-seq executable shell subr-x pcomplete comint ansi-osc ansi-color ring
mule-util info cl-extra thingatpt misearch multi-isearch files-x pcase
vc-git diff-mode easy-mmode vc-dispatcher bug-reference byte-opt gv
bytecomp byte-compile find-func shortdoc text-property-search help-fns
radix-tree help-mode cl-loaddefs cl-lib rmc iso-transl tooltip cconv
eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo x-toolkit
xinput2 x multi-tty make-network-process emacs)

Memory information:
((conses 16 95592 12304)
 (symbols 48 11056 0)
 (strings 32 35296 2090)
 (string-bytes 1 941437)
 (vectors 16 16336)
 (vector-slots 8 220716 11071)
 (floats 8 114 69)
 (intervals 56 1207 0)
 (buffers 976 16)
 (heap 1024 15858 2811))

bug#62189: 29.0.60; complete-symbol while inside add-to-list form prints a warning

[Eli Zaretskii]

> From: Spencer Baugh <sbaugh@janestreet.com>
> Date: Tue, 14 Mar 2023 12:09:43 -0400
> 
> 
> 1. Start emacs -Q and switch to *scratch*
> 2. Type (add-to-list f
> 3. Hit C-M-i to run complete-symbol
> 4. Observe the following warning and error in the *Messages* buffer:
> Warning: Optimization failure for add-to-list: Handler: add-to-list--anon-cmacro
> (wrong-number-of-arguments (3 . 5) 2)

That message is harmless, so I don't think it's a bug.

Adding Stefan, who introduced the warning, in case he has comments.

bug#62189: 29.0.60; complete-symbol while inside add-to-list form prints a warning

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> 1. Start emacs -Q and switch to *scratch*
>> 2. Type (add-to-list f
>> 3. Hit C-M-i to run complete-symbol
>> 4. Observe the following warning and error in the *Messages* buffer:
>> Warning: Optimization failure for add-to-list: Handler: add-to-list--anon-cmacro
>> (wrong-number-of-arguments (3 . 5) 2)
>
> That message is harmless,

Indeed, it's a mere warning about a failure to apply an optimization.

> so I don't think it's a bug.

But I do think it's a bug (I think we discussed this a few months ago,
probably in some other bug report): we should inhibit compiler macros
(and silence any other macro-expansion warnings)
during this kind of completion since it's normal to have
incomplete/invalid code at that point.

> Adding Stefan, who introduced the warning, in case he has comments.

The warning in valid and meaningful in other situations (e.g. if you
were to compile code that contains just `(add-to-list f)`), but here
it brings no value.


        Stefan

bug#62189: 29.0.60; complete-symbol while inside add-to-list form prints a warning

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Spencer Baugh <sbaugh@janestreet.com>,  62189@debbugs.gnu.org
> Date: Tue, 14 Mar 2023 16:28:08 -0400
> 
> But I do think it's a bug (I think we discussed this a few months ago,
> probably in some other bug report): we should inhibit compiler macros
> (and silence any other macro-expansion warnings)
> during this kind of completion since it's normal to have
> incomplete/invalid code at that point.

How do we silence these warnings in this case?

bug#62189: 29.0.60; complete-symbol while inside add-to-list form prints a warning

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> But I do think it's a bug (I think we discussed this a few months ago,
>> probably in some other bug report): we should inhibit compiler macros
>> (and silence any other macro-expansion warnings)
>> during this kind of completion since it's normal to have
>> incomplete/invalid code at that point.
>
> How do we silence these warnings in this case?

I don't think there's an existing mechanism for that.


        Stefan

bug#62189: 29.0.60; complete-symbol while inside add-to-list form prints a warning

[Eli Zaretskii]

> Cc: sbaugh@janestreet.com, 62189@debbugs.gnu.org
> Date: Wed, 15 Mar 2023 05:20:57 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > From: Stefan Monnier <monnier@iro.umontreal.ca>
> > Cc: Spencer Baugh <sbaugh@janestreet.com>,  62189@debbugs.gnu.org
> > Date: Tue, 14 Mar 2023 16:28:08 -0400
> > 
> > But I do think it's a bug (I think we discussed this a few months ago,
> > probably in some other bug report): we should inhibit compiler macros
> > (and silence any other macro-expansion warnings)
> > during this kind of completion since it's normal to have
> > incomplete/invalid code at that point.
> 
> How do we silence these warnings in this case?

So we should keep this bug open until such a mechanism is in place,
and otherwise do nothing about it?  Or did I misunderstand?