From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Tue, 12 Dec 2023 17:57:19 -0500 Message-ID: References: <878r919qfh.fsf@localhost> <83cyy11ln1.fsf@gnu.org> <87lecp84mf.fsf@localhost> <83ttrdx8j9.fsf@gnu.org> <87a5su261p.fsf@localhost> <838r8e24yy.fsf@gnu.org> <87y1gezspg.fsf@localhost> <834jj21z05.fsf@gnu.org> <87il7izo4l.fsf@localhost> <831qe61xrh.fsf@gnu.org> <87cyxqzmhh.fsf@localhost> <83zg0uzlgw.fsf@gnu.org> <87v8bhxzcu.fsf@localhost> <83y1gdxws8.fsf@gnu.org> <87jzrwm7ul.fsf@localhost> <87h6n0m781.fsf@localhost> <87v8935wik.fsf@localhost> <83msuftr0i.fsf@gnu.org> <87plzbxtxa.fsf@localhost> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17952"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Ihor Radchenko , Eli Zaretskii , 66117@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 12 23:59:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDBiU-0004SV-GH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Dec 2023 23:59:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDBiC-00009q-CI; Tue, 12 Dec 2023 17:58:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDBiB-00009O-6h for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2023 17:58:47 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rDBiA-0002yW-Uc for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2023 17:58:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rDBiQ-0003tf-5e for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2023 17:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Dec 2023 22:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.170242189214892 (code B ref 66117); Tue, 12 Dec 2023 22:59:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 12 Dec 2023 22:58:12 +0000 Original-Received: from localhost ([127.0.0.1]:57870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDBhc-0003s7-GX for submit@debbugs.gnu.org; Tue, 12 Dec 2023 17:58:12 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDBhZ-0003rm-WD for 66117@debbugs.gnu.org; Tue, 12 Dec 2023 17:58:10 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E719144485C; Tue, 12 Dec 2023 17:57:48 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1702421867; bh=ZSLQvONmT0azWRjuxhmZwretBOPAnEMUUFIEDC98RDg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=k1l2a4p4w85iErAesaAI4/n4uMuMXlWNlTTNiYSH6cdVTMDpJUO+L5+4r0MUgZUJ2 A+rsxpFcBqw3I1pBt/gJZPKTzs6j6L/GzsaKA/YUXs8sN5xZ4msHkD+iByoBaKu7Sb SXNpYK2UvIMF8RUE2tVhAepNw2S8Y8vZdiNOyP11Zdn4Q83s3Evi37O9YxWM7RU4Aj a0L6/IjUNeT/WkX6AsFZ2fBBvCzuWDq0O1BLjpAb/7apTBbUIGAEij8oWzhaWuqFhc APWD8uuHIjDIU/SI/lAEg2JEHEiatudOVHTESSwDaiyuzlAoIMWycOC3DyNJBiG/v5 AHqULyqjKkWBA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A8CAC444800; Tue, 12 Dec 2023 17:57:47 -0500 (EST) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 975CC120913; Tue, 12 Dec 2023 17:57:47 -0500 (EST) In-Reply-To: (Dmitry Gutov's message of "Tue, 12 Dec 2023 22:47:35 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276097 Archived-At: >> This said, in the case of `case-fold-search` I think there's a simpler >> solution: make it "buffer-local only", meaning that let-binding it >> affects only the current buffer (rather than affecting all the buffers >> which have not made it buffer-local yet). > Wouldn't that be a breaking change? And a non-obvious one. Yup. > E.g. company-dabbrev-code creates a dynamic binding for case-fold-search in > one place and then calls a function (company-dabbrev--search) that iterates > across all buffers with re-search-forward. I think we call this collateral damage. My suggestion was indeed not completely serious, tho I do think in the long run it's what we should do. BTW, regarding making BVAR slower, we could reduce its cost by introducing two versions of BVAR, so we only pay the price when accessing one of the problematic variables like `case-fold-search`. Stefan