From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs,gmane.emacs.orgmode Subject: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Tue, 09 Jan 2024 11:01:24 -0500 Message-ID: References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83cyyw4of7.fsf@gnu.org> <875y4ovct9.fsf@localhost> <875y04yq9s.fsf@localhost> <875y02y0da.fsf@localhost> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6838"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65734@debbugs.gnu.org, Eli Zaretskii , emacs-orgmode@gnu.org, Max Nikulin , iota@whxvd.name To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 17:02:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNEYV-0001Vl-OL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 17:02:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNEY9-0002N0-2s; Tue, 09 Jan 2024 11:01:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNEY7-0002Mb-C2 for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 11:01:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNEY7-0003Oc-2i for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 11:01:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNEYD-0005sd-Mq for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 11:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 16:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65734 X-GNU-PR-Package: emacs Original-Received: via spool by 65734-submit@debbugs.gnu.org id=B65734.170481610522575 (code B ref 65734); Tue, 09 Jan 2024 16:02:01 +0000 Original-Received: (at 65734) by debbugs.gnu.org; 9 Jan 2024 16:01:45 +0000 Original-Received: from localhost ([127.0.0.1]:40707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNEXw-0005s3-UW for submit@debbugs.gnu.org; Tue, 09 Jan 2024 11:01:45 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNEXs-0005rl-Cf for 65734@debbugs.gnu.org; Tue, 09 Jan 2024 11:01:43 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 96743100068; Tue, 9 Jan 2024 11:01:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1704816086; bh=v8Cu8hji29G32K+i2NCVQKswRVUUdDK8WHwDD1yDpsY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=d203HkjCEwOiEC/IqKB17MPKKawQuMgW7FAJZ4vxRJfp5AG3cMPyBIMv/dTuXJUzp oXNopO21F4zm6fvAmny6RKo5pf7Xepy6UcscU0GoatvJJ7b5VEd8i+o6sjdU2yevIx 7S5y092RAgVYeP51K+fiBIL0jGw/JG4Oe65+hL2BcIdPeRHlnBfwCFH01GQWDYtlb9 fcRg55MGe/T1CNTGuL85v47E6P3aY6DinmgG6Y/Id4ktzqxg2Vv1Nv6oiGUjKO/6pR 6645U1YgnVbTDwgPmDYdnR6PgKIUrkhjRDkR5m77KoRGDO22F64G8+qM6T0DkZc9Vf cskzChHm/gayw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4BDB510004C; Tue, 9 Jan 2024 11:01:26 -0500 (EST) Original-Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 09A02120BBA; Tue, 9 Jan 2024 11:01:26 -0500 (EST) In-Reply-To: <875y02y0da.fsf@localhost> (Ihor Radchenko's message of "Tue, 09 Jan 2024 15:47:45 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277634 gmane.emacs.orgmode:158940 Archived-At: >>> But in addition to that, I suspect that Org should probably not modify >>> visibility directly from the modification hooks. Instead, its >>> modification hook function should just stash the info somewhere and then >>> update the visibility later on, such as in a `post-command-hook`, timer, >>> `pre-redisplay-functions`, younameit. >> Good idea. At least, for this specific feature in Org mode. > Now, done. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f9702a09e Great, thanks! > Although, I am still interested to pursue feature request to allow > customizing `kill-whole-line' and `kill-line' by major modes. [ I'm sorry I didn't pay very much attention to this part. Naively, I'd suggest you use `remap` bindings for that, but I'm sure you're aware of that option, so you presumably have good reasons to want something else. ] Stefan