From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
Madhu <enometh@meer.net>,
73018@debbugs.gnu.org
Subject: bug#73018: 31.0.50; wdired + replace-regexp only modifies the visible portion of the buffer
Date: Tue, 10 Sep 2024 09:21:46 -0400 [thread overview]
Message-ID: <jwvwmjjirw7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <86tteo3wmh.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 10 Sep 2024 09:28:50 +0300")
> This is caused by commit 63588775fcb, so Cc-ing Stefan.
>
> But probably this commit just exposed the problem
> that existed before?
I think you're on to something.
> => (error "Match data clobbered by buffer modification hooks")
This comes from
if (search_regs.num_regs != num_regs)
error ("Match data clobbered by buffer modification hooks");
But this test is not doing what it is intended to do: it doesn't check
whether the match data has changed. It just checks whether the size of
the arrays we have allocated to hold the match data has changed.
I got to that conclusion after narrowing down the origin of the error
and finding out that the problem is that `search_regs.num_regs` is set
to 13 before the first call to `wdired--restore-properties` but to
23 afterwards.
We should probably use something like
ptrdiff_t
search_regs_last_reg (void)
{
ptrdiff_t i = search_regs.num_regs - 1;
while (i >= 0 && search_regs.start[i] < 0)
i--;
return i;
}
instead of `search_regs.num_regs`.
Stefan
next prev parent reply other threads:[~2024-09-10 13:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 2:33 bug#73018: 31.0.50; wdired + replace-regexp only modifies the visible portion of the buffer Madhu
2024-09-04 3:25 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-04 8:58 ` Madhu
2024-09-04 9:08 ` Madhu
2024-09-04 16:13 ` Juri Linkov
2024-09-05 12:12 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-05 16:51 ` Madhu
2024-09-05 16:51 ` Juri Linkov
2024-09-06 12:04 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-06 16:08 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-08 16:28 ` Juri Linkov
2024-09-09 14:55 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-09 17:13 ` Juri Linkov
2024-09-09 17:55 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-09 17:14 ` Juri Linkov
2024-09-10 6:28 ` Juri Linkov
2024-09-10 13:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-09-10 13:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-14 9:47 ` Eli Zaretskii
2024-09-15 13:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-15 15:02 ` Eli Zaretskii
2024-09-16 2:06 ` Madhu
2024-09-16 14:24 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-17 18:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-17 18:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwmjjirw7.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=73018@debbugs.gnu.org \
--cc=enometh@meer.net \
--cc=juri@linkov.net \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).