From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74523: 31.0.50; `apply` elements screw up undo in region Date: Mon, 25 Nov 2024 10:19:36 -0500 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27534"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 74523@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 25 16:20:32 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tFat6-00070v-6Z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Nov 2024 16:20:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tFasm-0003kF-2A; Mon, 25 Nov 2024 10:20:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFasd-0003gH-R8 for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2024 10:20:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tFasd-0001OU-Av for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2024 10:20:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=bF+CUMVfoo5GZi3cMCF0VUkyUreVNOi6tCsZ9oWqD18=; b=gdHS3ghnCsbck1aGA9YWvO4O+Y3PnqlmC+kU5+A+laR9f5bMcYIpU82WlvF5nihEXaF88gLWfNxbY3rhAmCt53aa0h50ti8GQsA3fSKvecZeSZqLP7TFQ5wmhxpCGbUV2K6P47DDL6mFSwH9Xs2r0bNeHEhUT10qh8nEqTX96ZbqBWP9AgrL03akjC2mE+lnABis/RxMiKSWODpOrYZm1TllW2UGEiiCSQwLqvLC1MCYH0ceRVMWml3hVJdl67CYKMffzfTrnIH3hP5rDkAB0MaJ8c1bobRzyGcMkPFFrJLajJOcUsPBi9TP7cLRXZ6oV2euMwl2FhK6YQiZvCi2EA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tFasc-0004w5-7H for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2024 10:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Nov 2024 15:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74523 X-GNU-PR-Package: emacs Original-Received: via spool by 74523-submit@debbugs.gnu.org id=B74523.173254798818937 (code B ref 74523); Mon, 25 Nov 2024 15:20:02 +0000 Original-Received: (at 74523) by debbugs.gnu.org; 25 Nov 2024 15:19:48 +0000 Original-Received: from localhost ([127.0.0.1]:40029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFasO-0004vN-Bt for submit@debbugs.gnu.org; Mon, 25 Nov 2024 10:19:48 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFasM-0004v7-4G for 74523@debbugs.gnu.org; Mon, 25 Nov 2024 10:19:47 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2FA1B100154; Mon, 25 Nov 2024 10:19:39 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1732547978; bh=s29zm+c9PLOPHe55FHoDPviNBFTn8reSI8msh0kt074=; h=From:To:Subject:In-Reply-To:References:Date:From; b=ElCbnSvUtvv7lZUMp4O714gGbLSvM1FVFQfRDl98xT+Fo+HjwsG0Gk/f73xuOW609 eaQeCQ1sY2E6r6cLAnqv5xQvXVmFxe/R+PETiXIHXnz1R2a3psWT5NvmmvjKedwqOc DVMqFskua6FbmzQ/TNbMPnTBYbkxgCRz1TCng1eTxyq1fCfXr8K94Gn3voJM9iIsff OMlE1dCLqrtAum0JbfOlfYmJUCsQPXW+yxG6fPVpXjnPQI6m07IqcBPnS+DthN+GRy DERf+5wVlkyHI/zQKteknmXsZGwEjvlX1tFMS6pFiealW6ou4pC2vfgVvr+vPU42GC 5Q9XAj1pD+lGg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8587C100035; Mon, 25 Nov 2024 10:19:38 -0500 (EST) Original-Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 62A6E12030F; Mon, 25 Nov 2024 10:19:38 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Mon, 25 Nov 2024 01:19:43 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295945 Archived-At: > We currently don't support `apply` undo-elements very well (if at all) > in the undo-in-region feature. > Those elements used to be rare, but now that `comment-region` and other > users of `combine-change-calls` generate them, it's not as rare. I pushed a patch which fixes the test I sent, but `apply` elements are still never included in undo-in-region. Fixing that won't be easy in general: we have no way for `undo-adjust-elt` to handle them correctly. Stefan