From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 74523@debbugs.gnu.org
Subject: bug#74523: 31.0.50; `apply` elements screw up undo in region
Date: Mon, 25 Nov 2024 10:19:36 -0500 [thread overview]
Message-ID: <jwvwmgrmjjf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwv34jfon6j.fsf-monnier+@gnu.org> (Stefan Monnier's message of "Mon, 25 Nov 2024 01:19:43 -0500")
> We currently don't support `apply` undo-elements very well (if at all)
> in the undo-in-region feature.
> Those elements used to be rare, but now that `comment-region` and other
> users of `combine-change-calls` generate them, it's not as rare.
I pushed a patch which fixes the test I sent, but `apply` elements are
still never included in undo-in-region.
Fixing that won't be easy in general: we have no way for
`undo-adjust-elt` to handle them correctly.
Stefan
prev parent reply other threads:[~2024-11-25 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 6:19 bug#74523: 31.0.50; `apply` elements screw up undo in region Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-25 15:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwmgrmjjf.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=74523@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).