From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#1806: dired-pop-to-buffer in wrong place Date: Mon, 18 May 2009 22:04:13 -0400 Message-ID: References: <87r63gzcap.fsf@jurta.org> <4965AE6B.6070802@gmx.at> <87fxjtmo4z.fsf@jurta.org> <49671922.4080609@gmx.at> <87zlhubw10.fsf@jurta.org> <496DF4B9.3080805@gmx.at> <496E5F58.7030304@gmx.at> <496F11C0.4080700@gmx.at> <87ocy8fajt.fsf@jurta.org> <4975F4D5.5030000@gmx.at> <87y6tk1j47.fsf@mail.jurta.org> <49F7FE14.8010107@gmx.at> <49FFE515.4020608@gmx.at> <87vdnzpks0.fsf@mail.jurta.org> <4A11184F.4030606@gmx.at> <87k54eexkd.fsf@mail.jurta.org> Reply-To: Stefan Monnier , 1806@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1242699147 30843 80.91.229.12 (19 May 2009 02:12:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 May 2009 02:12:27 +0000 (UTC) Cc: 1806@emacsbugs.donarmstrong.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 19 04:12:19 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M6EoU-0002zr-1B for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 May 2009 04:12:18 +0200 Original-Received: from localhost ([127.0.0.1]:54666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6EoT-0003ea-3B for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 May 2009 22:12:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M6EoP-0003eG-A3 for bug-gnu-emacs@gnu.org; Mon, 18 May 2009 22:12:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M6EoJ-0003cc-Jv for bug-gnu-emacs@gnu.org; Mon, 18 May 2009 22:12:12 -0400 Original-Received: from [199.232.76.173] (port=52005 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6EoJ-0003cZ-DC for bug-gnu-emacs@gnu.org; Mon, 18 May 2009 22:12:07 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:36281) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M6EoJ-0006i5-0r for bug-gnu-emacs@gnu.org; Mon, 18 May 2009 22:12:07 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M6EoI-0006XH-9w for bug-gnu-emacs@gnu.org; Mon, 18 May 2009 22:12:06 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4J2Bubh016626; Mon, 18 May 2009 19:11:57 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n4J2A63b015529; Mon, 18 May 2009 19:10:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 19 May 2009 02:10:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1806 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1806-submit@emacsbugs.donarmstrong.com id=B1806.124269860513215 (code B ref 1806); Tue, 19 May 2009 02:10:06 +0000 Original-Received: (at 1806) by emacsbugs.donarmstrong.com; 19 May 2009 02:03:25 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4J23LMv013202 for <1806@emacsbugs.donarmstrong.com>; Mon, 18 May 2009 19:03:22 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AugEAPavEUpMCovv/2dsb2JhbACBT8t9hAEFhWo X-IronPort-AV: E=Sophos;i="4.41,212,1241409600"; d="scan'208";a="38744548" Original-Received: from 76-10-139-239.dsl.teksavvy.com (HELO pastel.home) ([76.10.139.239]) by ironport2-out.teksavvy.com with ESMTP; 18 May 2009 22:03:15 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 4B7B67F29; Mon, 18 May 2009 22:04:13 -0400 (EDT) In-Reply-To: <87k54eexkd.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 19 May 2009 03:18:45 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Resent-Date: Mon, 18 May 2009 22:12:12 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:28004 Archived-At: > (if (or (one-window-p t) (not (window-full-width-p))) > ;; Don't mess with the window size, but ensure that the first > ;; line is fully visible. > (set-window-vscroll nil 0) > ;; Adjust the window to exactly fit the displayed calendar. > (fit-window-to-buffer nil nil calendar-minimum-window-height)) > Removing (not (window-full-width-p)) fixes this, but I don't know if this > change has some side effect. Often (not (window-full-width-p)) is used as a round-about and confusing way to check whether resizing is safe (in the sense that it doesn't risk deleting other windows along the way). In such cases, it is preferable to use window-safely-shrinkable-p, which is also less conservative. Stefan