From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#3984: 23.0.96; defadvice of call-interactively defeats interactive-p Date: Fri, 31 Jul 2009 15:31:54 -0400 Message-ID: References: <20E00C7675E64356BF2F0B2A7E0ABDB1@us.oracle.com> <2707E3CF212E4D7B801D2F2EEAF54373@us.oracle.com> Reply-To: Stefan Monnier , 3984@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1249069719 22375 80.91.229.12 (31 Jul 2009 19:48:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Jul 2009 19:48:39 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, 3984@emacsbugs.donarmstrong.com To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 31 21:48:32 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MWy5Y-0006Ij-GO for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Jul 2009 21:48:31 +0200 Original-Received: from localhost ([127.0.0.1]:49862 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWy5X-0004Ja-3Z for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Jul 2009 15:48:23 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWy45-0003xt-Li for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2009 15:46:53 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWy42-0003ta-0O for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2009 15:46:53 -0400 Original-Received: from [199.232.76.173] (port=41144 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWy41-0003tP-Mz for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2009 15:46:49 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:33162) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MWy40-0002lz-B5 for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2009 15:46:49 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6VJkiQZ016887; Fri, 31 Jul 2009 12:46:45 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n6VJeD0H016281; Fri, 31 Jul 2009 12:40:13 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 31 Jul 2009 19:40:13 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3984 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3984-submit@emacsbugs.donarmstrong.com id=B3984.124906872515709 (code B ref 3984); Fri, 31 Jul 2009 19:40:13 +0000 Original-Received: (at 3984) by emacsbugs.donarmstrong.com; 31 Jul 2009 19:32:05 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6VJW0ZI015695 for <3984@emacsbugs.donarmstrong.com>; Fri, 31 Jul 2009 12:32:01 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AsEFAI/jckpFpZgv/2dsb2JhbACBUtJmhBgFhyI X-IronPort-AV: E=Sophos;i="4.43,304,1246852800"; d="scan'208";a="42645523" Original-Received: from 69-165-152-47.dsl.teksavvy.com (HELO pastel.home) ([69.165.152.47]) by ironport2-out.teksavvy.com with ESMTP; 31 Jul 2009 15:31:55 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id DD6F8800B; Fri, 31 Jul 2009 15:31:54 -0400 (EDT) In-Reply-To: <2707E3CF212E4D7B801D2F2EEAF54373@us.oracle.com> (Drew Adams's message of "Fri, 31 Jul 2009 07:19:13 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-CrossAssassin-Score: 2 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Fri, 31 Jul 2009 15:46:53 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:29771 gmane.emacs.pretest.bugs:24899 Archived-At: > Unfortunately, the code with `interactive-p' is not mine. > The defadvice is mine, but it needs to work for user functions, > including those that call `interactive-p' or `called-interactively-p'. > Is there no way the Emacs implementation could be fixed to handle this > better? Couldn't it take into consideration the `ad-*' stuff that > results from advising `call-interactively'? IOW, couldn't it look for > `call-interactively' in its advised form also? There's probably some way to make it work, of course. Note that the same problem is likely to appear with other redefinitions of call-interactively (e.g. profiling, tracing, ...). Of course, another way to break these things is also to advise (and/or profile/trace/...) interactive-p. Stefan