unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 3224@debbugs.gnu.org
Subject: bug#3224: 23.0.92; vc-dir vs uniquify: wrong directory used
Date: Thu, 07 Jan 2010 14:53:44 -0500	[thread overview]
Message-ID: <jwvvdfdg0ab.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <f7ccd24b1001070709s3721c53m70976f104b259286@mail.gmail.com> (Juanma Barranquero's message of "Thu, 7 Jan 2010 16:09:48 +0100")

>> So for vc-dir, you want "*vc-dir*" instead of A, right?  So you want
>> file names of the form "/foo/dir-1/*vc-dir*" and "/foo/dir-2/*vc-dir*".
> For such dired-style buffers, uniquify uses list-buffers-directory, so
> the only way is as I did in the patch I just sent.
> Do you want that patch installed, assuming Dan does not oppose it?

Yes, it looks OK.

>> Yes, the docstring has been wrong since day one
> Well, I'm glad we agree on this, then.

Feel free to rename it to uniquify-buffer-dir-name and adjust the docstring.

> (As an aside: the previous time we discussed this, you suggested that
> `list-buffers-directory' has the wrong name, and also that perhaps it
> would be safer/wiser to create another variable for uses like the one
> in uniquify. I think we should revisit this issue after the release.)

Agreed,


        Stefan






  reply	other threads:[~2010-01-07 19:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f7ccd24b1001071940k28f0f35y508b7f1c26640f9f@mail.gmail.com>
2009-05-05 15:19 ` bug#3224: 23.0.92; vc-dir vs uniquify: wrong directory used Magnus Henoch
2009-08-04 12:30   ` Dan Nicolaescu
2010-01-06  4:00     ` Juanma Barranquero
2010-01-06  4:55       ` Dan Nicolaescu
2010-01-06  5:38       ` Stefan Monnier
2010-01-06 10:17         ` Juanma Barranquero
2010-01-06 14:28           ` Stefan Monnier
2010-01-07 11:14             ` Juanma Barranquero
2010-01-07 14:54               ` Stefan Monnier
2010-01-07 15:09                 ` Juanma Barranquero
2010-01-07 19:53                   ` Stefan Monnier [this message]
2010-01-07 23:05                     ` Juanma Barranquero
2010-01-08  3:22                       ` Stefan Monnier
2010-01-07 15:10               ` Dan Nicolaescu
2010-01-07 15:19                 ` Juanma Barranquero
2010-01-07 19:57                 ` Stefan Monnier
2010-01-08  3:41   ` bug#3224: marked as done (23.0.92; vc-dir vs uniquify: wrong directory used) Emacs bug Tracking System
2009-09-24 20:53 ` bug#4553: 23.1; uniquify gives *vc-dir* buffer the wrong name Tom Tromey
2009-09-24 21:32   ` Dan Nicolaescu
2009-09-24 21:40     ` Processed: " Emacs bug Tracking System
2010-01-08  3:41   ` bug#4553: marked as done (23.1; uniquify gives *vc-dir* buffer the wrong name) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvvdfdg0ab.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=3224@debbugs.gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).