From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#6490: 24.0.50; src/lread.c: old style backquote bug? Date: Sun, 04 Jul 2010 23:50:26 +0200 Message-ID: References: <86iq5bifzr.wl%%cc9230e4f6b11649d75e8c3813911dbe1dd37419@be.to> <8639w3vjvm.wl%%cc9230e4f6b11649d75e8c3813911dbe1dd37419@be.to> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1278280796 20140 80.91.229.12 (4 Jul 2010 21:59:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 4 Jul 2010 21:59:56 +0000 (UTC) Cc: 6490@debbugs.gnu.org To: Tetsurou Okazaki Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 04 23:59:55 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OVXE7-0004Xh-AQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Jul 2010 23:59:51 +0200 Original-Received: from localhost ([127.0.0.1]:53699 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVXE6-0005zp-Vr for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Jul 2010 17:59:51 -0400 Original-Received: from [140.186.70.92] (port=41141 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVXDz-0005zk-TF for bug-gnu-emacs@gnu.org; Sun, 04 Jul 2010 17:59:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OVXDy-0004yS-Kz for bug-gnu-emacs@gnu.org; Sun, 04 Jul 2010 17:59:43 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46582) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVXDy-0004yO-H9 for bug-gnu-emacs@gnu.org; Sun, 04 Jul 2010 17:59:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OVX5a-0003lF-KH; Sun, 04 Jul 2010 17:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jul 2010 21:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 6490-submit@debbugs.gnu.org id=B6490.127828024114449 (code B ref 6490); Sun, 04 Jul 2010 21:51:02 +0000 Original-Received: (at 6490) by debbugs.gnu.org; 4 Jul 2010 21:50:41 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVX5F-0003l0-6x for submit@debbugs.gnu.org; Sun, 04 Jul 2010 17:50:41 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVX5D-0003ku-Ip for 6490@debbugs.gnu.org; Sun, 04 Jul 2010 17:50:40 -0400 Original-Received: from alfajor.home (vpn-132-204-232-122.acd.umontreal.ca [132.204.232.122]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id o64LoRT4006653; Sun, 4 Jul 2010 17:50:29 -0400 Original-Received: by alfajor.home (Postfix, from userid 20848) id CE984BB541; Sun, 4 Jul 2010 23:50:26 +0200 (CEST) In-Reply-To: <8639w3vjvm.wl%%cc9230e4f6b11649d75e8c3813911dbe1dd37419@be.to> (Tetsurou Okazaki's message of "Thu, 01 Jul 2010 14:41:49 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3570=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 04 Jul 2010 17:51:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38226 Archived-At: >> > Attached patch for Emacs fixes this error. >> I'm glad the patch fixes things for you, since this patch indeed looks >> perfectly harmless, but I'm a bit puzzled because it doesn't just look >> harmless: it looks to me like the patch does change anything to the way >> the code works. So could you explain to me how&why the patch fixes >> the problem? I'm probably just overlooking some "obvious" detail, > The changes committed in rev:100605 reassigns the next character to > the variable `c'. When the next character is SPC (32, #o40, #x20), > old style backquote is detected. > if (first_in_list && (c = READCHAR, UNREAD (c), c == ' ')) > { > Vold_style_backquotes = Qt; > goto default_label; > } > But backquote handling is skipped because `c' is SPC. > default_label: > if (c <= 040) goto retry; > ... old style backquote handling ... > My patch avoids reassignment of `c' not to skip old style > backquote handling. Thanks, that makes perfect sense now. I've installed it now. > To keep more compatibility with released Emacs, it is preferable to > allow a character such as \r or \n after the old style backquote. I haven't seen any such situation yet, and since old-style backquotes are on the way out (effectively obsolete since something like Emacs-20, and officially obsolete since Emacs-22.1), I'll wait to see actual cases before adding such exceptions, Stefan