From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10117: duplicate evaluation of after-change-functions hooks in revert-buffer Date: Thu, 01 Dec 2011 15:23:29 -0500 Message-ID: References: <4ECCD677.1090900@inria.fr> <4ECD0A5D.90907@inria.fr> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: dough.gmane.org 1322771050 11710 80.91.229.12 (1 Dec 2011 20:24:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 1 Dec 2011 20:24:10 +0000 (UTC) Cc: 10117-done@debbugs.gnu.org To: Tiphaine Turpin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 01 21:24:06 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RWDAn-00012I-DJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Dec 2011 21:24:01 +0100 Original-Received: from localhost ([::1]:40401 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWDAm-000482-Vt for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Dec 2011 15:24:00 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:40587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWDAf-0003z5-GJ for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2011 15:23:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RWDAd-0004mZ-FN for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2011 15:23:53 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWDAd-0004mH-Df for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2011 15:23:51 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RWDAn-0003Jh-Ol for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2011 15:24:01 -0500 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Dec 2011 20:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 10117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Mail-Followup-To: 10117@debbugs.gnu.org, monnier@iro.umontreal.ca Original-Received: via spool by 10117-done@debbugs.gnu.org id=D10117.132277102312720 (code D ref 10117); Thu, 01 Dec 2011 20:24:01 +0000 Original-Received: (at 10117-done) by debbugs.gnu.org; 1 Dec 2011 20:23:43 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWDAV-0003J6-DE for submit@debbugs.gnu.org; Thu, 01 Dec 2011 15:23:43 -0500 Original-Received: from relais.videotron.ca ([24.201.245.36]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWDAT-0003Ix-I4 for 10117-done@debbugs.gnu.org; Thu, 01 Dec 2011 15:23:42 -0500 Original-Received: from ceviche.home ([173.176.12.77]) by VL-VM-MR001.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0LVJ00AJKKL2HY60@VL-VM-MR001.ip.videotron.ca> for 10117-done@debbugs.gnu.org; Thu, 01 Dec 2011 15:22:14 -0500 (EST) Original-Received: by ceviche.home (Postfix, from userid 20848) id AB7FD660D4; Thu, 01 Dec 2011 15:23:29 -0500 (EST) In-reply-to: <4ECD0A5D.90907@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 01 Dec 2011 15:24:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54574 Archived-At: >> change-functions "by hand". Do you have a small test case reproducing >> the problem? > Here is an example: > First open the attached file in Emacs and evaluate it. Then: > echo ';Hi!' >>revert-bug.el > The *Messages* buffer shows the following: > modify [175, 180[ (old-len=0) [2 times] Indeed, I see that too. I've installed the patch below which should fix it. Thanks for the simple test case. Stefan === modified file 'src/fileio.c' --- src/fileio.c 2011-11-26 21:40:41 +0000 +++ src/fileio.c 2011-12-01 20:14:53 +0000 @@ -4100,6 +4100,16 @@ adjust_after_insert (PT, PT_BYTE, PT + inserted, PT_BYTE + inserted, inserted); + /* Call after-change hooks for the inserted text, aside from the case + of normal visiting (not with REPLACE), which is done in a new buffer + "before" the buffer is changed. */ + if (inserted > 0 && total > 0 + && (NILP (visit) || !NILP (replace))) + { + signal_after_change (PT, 0, inserted); + update_compositions (PT, PT, CHECK_BORDER); + } + /* Now INSERTED is measured in characters. */ handled: @@ -4270,16 +4280,6 @@ unbind_to (count1, Qnil); } - /* Call after-change hooks for the inserted text, aside from the case - of normal visiting (not with REPLACE), which is done in a new buffer - "before" the buffer is changed. */ - if (inserted > 0 && total > 0 - && (NILP (visit) || !NILP (replace))) - { - signal_after_change (PT, 0, inserted); - update_compositions (PT, PT, CHECK_BORDER); - } - if (!NILP (visit) && current_buffer->modtime == -1) {