From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jambunathan K <kjambunathan@gmail.com>
Cc: 12159@debbugs.gnu.org
Subject: bug#12159: 24.1.50; vc-dir: Need a way to hide unregistered files
Date: Sun, 12 Aug 2012 10:13:05 -0400 [thread overview]
Message-ID: <jwvvcgo42xk.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87boigj2ti.fsf@gmail.com> (Jambunathan K.'s message of "Sun, 12 Aug 2012 07:20:49 +0530")
> + * vc/vc-dir.el (vc-dir-hide-these-states): New custom variable.
Don't bother. Just always default to up-to-date.
> +(defun vc-dir-hide-some-states (&optional states)
Make it `state' and not a list.
> + (interactive
> + ;; Interactive use.
Redundant comment.
> + ;; Non-interactive use.
> + (unless (called-interactively-p 'any)
> + (setq states (or states vc-dir-hide-these-states)))
The test is wrong (it prevents non-interactive use where you specify
the state explicitly).
The above should simply be (unless state (setq state 'up-to-date)).
> +(defun vc-dir-hide-up-to-date ()
> + "Hide up-to-date items from display."
> + (interactive)
> + (vc-dir-hide-some-states '("up-to-date")))
Why bother?
Stefan
next prev parent reply other threads:[~2012-08-12 14:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 18:07 bug#12159: 24.1.50; vc-dir: Need a way to hide unregistered files Jambunathan K
2012-08-08 18:27 ` Glenn Morris
2012-08-08 18:52 ` Jambunathan K
2012-08-09 1:54 ` Stefan Monnier
2012-08-11 17:41 ` Jambunathan K
2012-08-11 22:40 ` Stefan Monnier
2012-08-12 1:50 ` Jambunathan K
2012-08-12 7:37 ` Andreas Schwab
2012-08-12 9:58 ` Jambunathan K
2012-08-12 10:02 ` Andreas Schwab
2012-08-12 11:04 ` Jambunathan K
2012-08-12 14:07 ` Andreas Schwab
2012-08-12 14:13 ` Stefan Monnier [this message]
2012-08-12 14:22 ` Jambunathan K
2012-08-12 19:11 ` Jambunathan K
2012-08-12 19:20 ` Eli Zaretskii
2012-08-12 19:40 ` Jambunathan K
2012-08-13 14:21 ` Bastien
2012-08-12 22:35 ` Stefan Monnier
2012-08-13 17:46 ` Jambunathan K
2012-08-13 21:34 ` Stefan Monnier
2012-08-13 22:09 ` Bastien
2012-08-14 4:28 ` Jambunathan K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvcgo42xk.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=12159@debbugs.gnu.org \
--cc=kjambunathan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).