From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face Date: Sat, 22 Dec 2012 11:56:28 -0500 Message-ID: References: <50D176DF.4080102@gmx.at> <83zk1anhzd.fsf@gnu.org> <50D2E16B.70804@gmx.at> <50D349EF.9020003@gmx.at> <50D428D2.9090105@gmx.at> <50D5DA43.1070008@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1356195417 28191 80.91.229.3 (22 Dec 2012 16:56:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Dec 2012 16:56:57 +0000 (UTC) Cc: 13225@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 22 17:57:11 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TmSNo-0002qF-Gw for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2012 17:57:08 +0100 Original-Received: from localhost ([::1]:40967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TmSNa-0000wv-FS for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2012 11:56:54 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TmSNR-0000wQ-C2 for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2012 11:56:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TmSNO-00025p-Sg for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2012 11:56:45 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TmSNO-00025l-Q3 for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2012 11:56:42 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TmSNi-0005nG-C0 for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2012 11:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2012 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13225-submit@debbugs.gnu.org id=B13225.135619541222252 (code B ref 13225); Sat, 22 Dec 2012 16:57:02 +0000 Original-Received: (at 13225) by debbugs.gnu.org; 22 Dec 2012 16:56:52 +0000 Original-Received: from localhost ([127.0.0.1]:55721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmSNY-0005mr-0n for submit@debbugs.gnu.org; Sat, 22 Dec 2012 11:56:52 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:37361) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TmSNW-0005ml-T8 for 13225@debbugs.gnu.org; Sat, 22 Dec 2012 11:56:51 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxLDj/2dsb2JhbABEsEiDSYEIghUBAQQBJy8jBQsLNBIUGA0kiBwFugmQRAOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210564063" Original-Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 22 Dec 2012 11:56:29 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 2569258EA5; Sat, 22 Dec 2012 11:56:28 -0500 (EST) In-Reply-To: <50D5DA43.1070008@gmx.at> (martin rudalics's message of "Sat, 22 Dec 2012 17:05:23 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68911 Archived-At: >>> ... and while we compute the mode line we don't care whether >>> selected_frame-> selected_window equals selected_window. >> What makes you think so? > So we do? I believe we always do, especially when (potentially) running Elisp code, which can in turn run pretty much any code. >>> Wouldn't it be more correct to handle this as in >>> run_window_configuration_change_hook? >> I don't know how run_window_configuration_change_hook handles "this". > Hmmm... that's your code so I can only provide my interpretation of it: > run_window_configuration_change_hook uses select_window_norecord (which > preserves the selected_frame->selected_window = selected_window property > we, according to your question above, do care about. display_mode_lines > does only XSETWINDOW (selected_window, w) which does not preserve that > property IIUC. Oh, that's what you mean. Yes, maybe we could/should just use select_window(_norecord) (which is not just the way run_window_configuration_change_hook does it, but is more generally the normal way to do it). My recent change already brings display_mode_lines closer to what select_window does. Stefan