unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo Liu <sdl.web@gmail.com>
Cc: "Óscar Fuentes" <ofv@wanadoo.es>, Bastien <bzg@altern.org>,
	15525@debbugs.gnu.org
Subject: bug#15525: 24.3; register-read-with-preview
Date: Sun, 06 Oct 2013 12:59:41 -0400	[thread overview]
Message-ID: <jwvvc1al4m8.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <m11u3z5fa6.fsf@gmail.com> (Leo Liu's message of "Sun, 06 Oct 2013 10:01:05 +0800")

>> I wonder if the default shouldn't be "infinite delay", so as to preserve
>> existing behavior?
> Done. (If it is OK I like to turn it on for a month or two for some
> testing and then turn it off eventually)

I'm OK with enabling it tentatively, and see if people complain.
You might like to use a slightly longer delay, tho.  For me, 0.5s makes
it pop up the list pretty much all the time (I guess I'm slow).

>> I think the only valid reason to disable the help-char here is if it
>> prevents access to an existing register.  So we can get rid of this
>> custom var and instead make sure we only obey help-char if there is no
>> existing register by that name.
> The trouble is when you create new registers.

The code should not let you create new registers that match help-char.

> But I remove that custom variable anyway since it won't be used
> much. It is unlikely C-h be used as a register.

BTW, we could/should also accept help-event-list events.

> If no one objects I would like to install the attached patch.

Go ahead,


        Stefan





  reply	other threads:[~2013-10-06 16:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-04  5:57 bug#15525: 24.3; register-read-with-preview Leo Liu
2013-10-04 13:57 ` Stefan Monnier
2013-10-04 16:02   ` Bastien
2013-10-05  3:19   ` Leo Liu
2013-10-05 16:30     ` Stefan Monnier
2013-10-06  2:01       ` Leo Liu
2013-10-06 16:59         ` Stefan Monnier [this message]
2013-10-07  2:35           ` Leo Liu
2013-10-07  4:13             ` Stefan Monnier
2013-10-10 12:56               ` Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvvc1al4m8.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=15525@debbugs.gnu.org \
    --cc=bzg@altern.org \
    --cc=ofv@wanadoo.es \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).