From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: 17642@debbugs.gnu.org
Subject: bug#17642: pre-command-hook has thousands of `clear-transient-map' in 24.3.91.1
Date: Fri, 30 May 2014 21:36:59 -0400 [thread overview]
Message-ID: <jwvvbsmd95u.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87vbsnylw8.fsf@gmail.com> (Thierry Volpiatto's message of "Fri, 30 May 2014 23:52:39 +0200")
> Helm is using `set-transient-map' a lot and it seems `set-transient-map'
> doesn't remove properly its `clearfun' from `pre-command-hook' or more
> exactly the `clearfun' doesn't remove itself from `pre-command-hook'.
Clearly, that's what we see, but the question is "why". The code does do
(remove-hook 'pre-command-hook clearfun)
so why is this code not run?
Maybe it's because of the new condition:
((not (eq map (cadr overriding-terminal-local-map)))
;; There's presumably some other transient-map in
;; effect. Wait for that one to terminate before we
;; remove ourselves.
;; For example, if isearch and C-u both use transient
;; maps, then the lifetime of the C-u should be nested
;; within isearch's, so the pre-command-hook of
;; isearch should be suspended during the C-u one so
;; we don't exit isearch just because we hit 1 after
;; C-u and that 1 exits isearch whereas it doesn't
;; exit C-u.
t)
IOW, could it be that Helm keeps adding new transient-maps, rather than
follow the usual "nesting" of transient maps?
Stefan
next prev parent reply other threads:[~2014-05-31 1:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 13:19 bug#17642: pre-command-hook has thousands of `clear-transient-map' in 24.3.91.1 Le Wang
2014-05-30 19:55 ` Stefan Monnier
2014-05-30 21:52 ` Thierry Volpiatto
2014-05-31 1:36 ` Stefan Monnier [this message]
[not found] ` <87egza34kw.fsf@gmail.com>
[not found] ` <jwvoaye9fdu.fsf-monnier+emacsbugs@gnu.org>
[not found] ` <871tv9orbu.fsf@gmail.com>
2014-05-31 20:04 ` Stefan Monnier
2014-06-01 2:35 ` Le Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvbsmd95u.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=17642@debbugs.gnu.org \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).