unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#19796: 25.0.50; Regression: highlight-lines-matching-regexp can't re-highlight the same string
@ 2015-02-07  6:57 Dima Kogan
  2015-02-11 21:41 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Dima Kogan @ 2015-02-07  6:57 UTC (permalink / raw)
  To: 19796

Hi.

The following commit broke some hi-lock functionality:

commit 6711a21f1125c0047c56eb266eb374c1ec90a967
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Wed May 28 23:45:29 2014 -0400

    ...
    * lisp/hi-lock.el (hi-lock-mode, hi-lock-unface-buffer)
    (hi-lock-set-pattern, hi-lock-set-file-patterns): Use font-lock-flush.
    ...


Recipe to reproduce:

1. seq 1000 > /tmp/dat
2. emacs -Q /tmp/dat
3. M-s h l 7       (highlight all lines matching "7")
4. M-s h u [enter] (un-highlight the default, "7" in this case)
5. M-s h l 7       (highlight all lines matching "7" again)

After that commit, nothing is highlighted anymore






^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#19796: 25.0.50; Regression: highlight-lines-matching-regexp can't re-highlight the same string
  2015-02-07  6:57 bug#19796: 25.0.50; Regression: highlight-lines-matching-regexp can't re-highlight the same string Dima Kogan
@ 2015-02-11 21:41 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2015-02-11 21:41 UTC (permalink / raw)
  To: Dima Kogan; +Cc: 19796-done

> 1. seq 1000 > /tmp/dat
> 2. emacs -Q /tmp/dat
> 3. M-s h l 7       (highlight all lines matching "7")
> 4. M-s h u [enter] (un-highlight the default, "7" in this case)
> 5. M-s h l 7       (highlight all lines matching "7" again)

> After that commit, nothing is highlighted anymore

Yuck, the old behavior looked right but was subtly wrong (the
highlighting at step 5 was done via font-lock whereas it was done with
overlays at step 3), and the recent change made the difference "more
visible" ;-)

The real problem is in font-lock, I think, but I don't have the courage
to fix it now, so I've installed a workaround that I hope will be sufficient.


        Stefan





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-11 21:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-07  6:57 bug#19796: 25.0.50; Regression: highlight-lines-matching-regexp can't re-highlight the same string Dima Kogan
2015-02-11 21:41 ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).