unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 19704@debbugs.gnu.org, Noam Postavsky <npostavs@users.sourceforge.net>
Subject: bug#19704: 25.0.50; funcall with hard-quote inside cl-labels uses the local function binding
Date: Fri, 10 Jun 2016 22:42:11 -0400	[thread overview]
Message-ID: <jwvvb1gxxd6.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <a5036f66-db68-90b3-dd2f-fa99d9ccefe5@yandex.ru> (Dmitry Gutov's message of "Sat, 11 Jun 2016 01:06:55 +0300")

>> Seems that macroexp--expand-all got too aggressive, patch below
>> teaches it to back off in case of locally defined functions:
> Thanks, Noam. Seems to work fine here.
> Stefan, how does it look to you?

Looks OK, tho a bit on the hackish side.  Maybe a simpler solution is to
replace  (or 'quote 'function) with 'function (i.e. only apply the
optimization to (funcall #'foo ...) and not to (funcall 'foo ...)).


        Stefan





  reply	other threads:[~2016-06-11  2:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 15:22 bug#19704: 25.0.50; funcall with hard-quote inside cl-labels uses the local function binding Dmitry Gutov
2016-06-10  2:37 ` Noam Postavsky
2016-06-10 22:06   ` Dmitry Gutov
2016-06-11  2:42     ` Stefan Monnier [this message]
2016-06-11  2:56       ` Noam Postavsky
2016-06-11 21:38         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvvb1gxxd6.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=19704@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).