From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#33247: makefile mode comment color Date: Tue, 06 Nov 2018 08:25:39 -0500 Message-ID: References: <20181106094721.92934.qmail@mail.muc.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1541511045 26246 195.159.176.226 (6 Nov 2018 13:30:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Nov 2018 13:30:45 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33247@debbugs.gnu.org, =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 06 14:30:41 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK1RH-0006jN-L5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2018 14:30:39 +0100 Original-Received: from localhost ([::1]:41129 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK1TK-00049h-TM for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2018 08:32:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK1Pq-0001j9-1h for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 08:29:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK1Mp-0002UE-GQ for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 08:26:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60104) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gK1Mo-0002Si-EG for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 08:26:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gK1Mo-00061U-4F for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 08:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Nov 2018 13:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33247 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33247-submit@debbugs.gnu.org id=B33247.154151074523124 (code B ref 33247); Tue, 06 Nov 2018 13:26:02 +0000 Original-Received: (at 33247) by debbugs.gnu.org; 6 Nov 2018 13:25:45 +0000 Original-Received: from localhost ([127.0.0.1]:36129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK1MX-00060u-Ib for submit@debbugs.gnu.org; Tue, 06 Nov 2018 08:25:45 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:33339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK1MV-00060m-2P for 33247@debbugs.gnu.org; Tue, 06 Nov 2018 08:25:43 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id wA6DPecD006712; Tue, 6 Nov 2018 08:25:41 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 16D296A522; Tue, 6 Nov 2018 08:25:39 -0500 (EST) In-Reply-To: <20181106094721.92934.qmail@mail.muc.de> (Alan Mackenzie's message of "6 Nov 2018 09:47:21 -0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6412=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6412> : inlines <6952> : streams <1803480> : uri <2745171> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152099 Archived-At: > Why do we have this setting for makefiles at all? That's to handle the /bin/sh comments on the command lines of rules, where the code is run by /bin/sh and hence obeys the corresponding rules. E.g. foo.o: foo.c echo This is#not a comment $(CC) $(CFLAGS) -o $@ $< #This is an sh comment > Are there any such > restrictions on comments in Makefiles? Stefan? Maybe we should conditionalize on the presence of a leading TAB at the beginning of the line. BTW, I recently saw that the above is wrong in cases like foo.o: foo.c @#An sh comment not recognized by current makefile mode $(CC) $(CFLAGS) -o $@ $< #This is a comment so if you can fix both of those while you're there, that'd be great! -- Stefan